From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Wainer dos Santos Moschetta <wainersm@redhat.com>,
Cleber Rosa <crosa@redhat.com>
Subject: Re: [PATCH 3/3] python/qemu/qmp.py: Fix settimeout operation
Date: Fri, 9 Oct 2020 21:35:49 +0200 [thread overview]
Message-ID: <75b4cd8f-f7b1-a182-ce5a-27bf2c9f1612@redhat.com> (raw)
In-Reply-To: <20201009175123.249009-4-jsnow@redhat.com>
On 10/9/20 7:51 PM, John Snow wrote:
> We enabled callers to interface directly with settimeout, but this
> reacts poorly with blocking/nonblocking operation; as they are using the
> same internal mechanism.
>
> 1. Whenever we change the blocking mechanism temporarily, always set it
> back to what it was afterwards.
>
> 2. Disallow callers from setting a timeout of "0", which means
> Non-blocking mode. This is going to create more weird problems than
> anybody wants, so just forbid it.
>
> I opt not to coerce '0' to 'None' to maintain the principal of least
> surprise in mirroring the semantics of Python's interface.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/qmp.py | 23 +++++++++++++++++------
> 1 file changed, 17 insertions(+), 6 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-10-09 19:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 17:51 [PATCH 0/3] python/qemu: strictly typed mypy conversion, pt3 John Snow
2020-10-09 17:51 ` [PATCH 1/3] python: add mypy config John Snow
2020-10-13 9:15 ` Bin Meng
2020-10-13 17:00 ` John Snow
2020-10-09 17:51 ` [PATCH 2/3] python/qemu/qmp.py: re-raise OSError when encountered John Snow
2020-10-09 19:34 ` Philippe Mathieu-Daudé
2020-10-09 17:51 ` [PATCH 3/3] python/qemu/qmp.py: Fix settimeout operation John Snow
2020-10-09 19:35 ` Philippe Mathieu-Daudé [this message]
2020-10-09 17:52 ` [PATCH 0/3] python/qemu: strictly typed mypy conversion, pt3 John Snow
2020-10-12 14:54 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75b4cd8f-f7b1-a182-ce5a-27bf2c9f1612@redhat.com \
--to=philmd@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).