From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: pbonzini@redhat.com, mreitz@redhat.com, kwolf@redhat.com,
den@virtuozzo.com, rjones@redhat.com, berrange@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-nbd: drop old-style negotiation
Date: Wed, 3 Oct 2018 12:31:11 -0500 [thread overview]
Message-ID: <75bd09f2-2e18-9c82-d918-0fc99d5279f5@redhat.com> (raw)
In-Reply-To: <20181003170228.95973-2-vsementsov@virtuozzo.com>
On 10/3/18 12:02 PM, Vladimir Sementsov-Ogievskiy wrote:
> Use new-style negotiation always, with default "" (empty) export name
> if it is not specified with '-x' option.
If we like this approach (over mine of keeping oldstyle, but via an
explicit -O option), then this commit message should add the following:
qemu as client can manage either style since 2.6.0, commit 69b49502d8
For comparison:
nbdkit 1.3 switched its default to newstyle (Jan 2018):
https://github.com/libguestfs/nbdkit/commit/b2a8aecc
https://github.com/libguestfs/nbdkit/commit/8158e773
nbd 3.10 dropped oldstyle long ago (Mar 2015):
https://github.com/NetworkBlockDevice/nbd/commit/36940193
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> qemu-nbd.c | 25 ++++++-------------------
> 1 file changed, 6 insertions(+), 19 deletions(-)
>
If we like your patch over mine,
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-10-03 17:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 17:02 [Qemu-devel] [PATCH 0/2] nbd server: drop old-style negotiation Vladimir Sementsov-Ogievskiy
2018-10-03 17:02 ` [Qemu-devel] [PATCH 1/2] qemu-nbd: " Vladimir Sementsov-Ogievskiy
2018-10-03 17:31 ` Eric Blake [this message]
2018-10-03 17:02 ` [Qemu-devel] [PATCH 2/2] nbd/server: " Vladimir Sementsov-Ogievskiy
2018-10-03 17:35 ` Eric Blake
2018-10-03 17:32 ` [Qemu-devel] [PATCH 0/2] nbd server: " Eric Blake
2018-10-03 17:59 ` Vladimir Sementsov-Ogievskiy
2018-10-03 18:08 ` Eric Blake
2018-10-03 20:30 ` Richard W.M. Jones
2018-10-04 12:10 ` Vladimir Sementsov-Ogievskiy
2018-10-04 12:22 ` Richard W.M. Jones
2018-10-03 20:44 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75bd09f2-2e18-9c82-d918-0fc99d5279f5@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=den@virtuozzo.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).