From: Thomas Huth <thuth@redhat.com>
To: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
Cc: "Fam Zheng" <fam@euphon.net>,
"Laurent Vivier" <lvivier@redhat.com>,
"S.E.Harris@kent.ac.uk" <S.E.Harris@kent.ac.uk>,
"mrolnik@gmail.com" <mrolnik@gmail.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Markus Armbruster" <armbru@redhat.com>,
"me@xcancerberox.com.ar" <me@xcancerberox.com.ar>,
"richard.henderson@linaro.org" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"imammedo@redhat.com" <imammedo@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alistair Francis" <Alistair.Francis@wdc.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"dovgaluk@ispras.ru" <dovgaluk@ispras.ru>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"qemu-riscv@nongnu.org" <qemu-riscv@nongnu.org>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>
Subject: Re: [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic
Date: Sat, 25 Jan 2020 18:08:18 +0100 [thread overview]
Message-ID: <75c4ac1f-e5cb-1f6c-92d8-2cf5bb0ebea6@redhat.com> (raw)
In-Reply-To: <CAL1e-=irw8HhXyJmdUm_+HXReVtk=SWkSCmPce-7artL6N7oUw@mail.gmail.com>
On 25/01/2020 11.48, Aleksandar Markovic wrote:
>
> On Friday, January 24, 2020, Philippe Mathieu-Daudé <f4bug@amsat.org
> <mailto:f4bug@amsat.org>> wrote:
>
> From: Michael Rolnik <mrolnik@gmail.com <mailto:mrolnik@gmail.com>>
>
> This includes:
> - CPU data structures
> - object model classes and functions
> - migration functions
> - GDB hooks
>
> I have an objection over this patch.
>
> It contains many diverse logical units squashed into a patch, and
> therefore is not in accordance to our submission giidelines.
I think you have to decide on a case by case basis. This is a new target
for a hobbyist board ... so I think you don't have to thaaat strict here.
> If we accept this patch, we will be setting a bad precedent, that may
> misled future platform contributors. additionally, this patch may be
> singled out in our countribution guidelines as the example how not to do
> a parch, which is probably not what Michael want to be exposed to.
Honestly, I'd leave that decision to the person who picks up the patch
and sends a pull request, i.e. Richard in this case, I assume.
> Splitting patches is tedius, but overall not that difficult or time
> consuming task.
OTOH hand, we've seen more than 40 iterations of the patch series
already. Michael invested a lot of time into this series, so if you make
him respin forever, he'll certainly rather lose interest at one point in
time. So I'd say if Richard is fine with the series, I'd rather not like
to see yet another iteration on the mailing list again and rather see a
pull request for these patches instead.
Thomas
next prev parent reply other threads:[~2020-01-25 17:09 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 0:51 [PATCH rc2 00/25] target/avr merger Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic Philippe Mathieu-Daudé
2020-01-25 10:48 ` Aleksandar Markovic
2020-01-25 17:08 ` Thomas Huth [this message]
2020-01-26 12:15 ` Joaquin de Andres
2020-01-27 2:25 ` Aleksandar Markovic
2020-01-27 8:53 ` Michael Rolnik
2020-01-27 9:24 ` Joaquin de Andres
2020-01-27 9:48 ` Michael Rolnik
2020-01-27 10:39 ` Joaquin de Andres
2020-01-27 13:27 ` Joaquin de Andres
2020-01-27 13:38 ` Michael Rolnik
2020-01-31 1:22 ` Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 02/25] target/avr: Add instruction helpers Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 03/25] target/avr: Add instruction translation - Registers definition Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 04/25] target/avr: Add instruction translation - Arithmetic and Logic Instructions Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 05/25] target/avr: Add instruction translation - Branch Instructions Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 06/25] target/avr: Add instruction translation - Data Transfer Instructions Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 07/25] target/avr: Add instruction translation - Bit and Bit-test Instructions Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 08/25] target/avr: Add instruction translation - MCU Control Instructions Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 09/25] target/avr: Add instruction translation - CPU main translation function Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 10/25] target/avr: Add instruction disassembly function Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 11/25] hw/char: Add limited support for Atmel USART peripheral Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 12/25] hw/timer: Add limited support for Atmel 16 bit timer peripheral Philippe Mathieu-Daudé
2020-01-24 8:16 ` Thomas Huth
2020-01-24 12:50 ` Philippe Mathieu-Daudé
2020-01-30 22:45 ` Aleksandar Markovic
2020-01-24 10:42 ` Alex Bennée
2020-01-24 10:51 ` Philippe Mathieu-Daudé
2020-01-24 12:07 ` Sarah Harris
2020-01-30 22:44 ` Aleksandar Markovic
2020-01-31 11:20 ` Philippe Mathieu-Daudé
2020-01-24 12:52 ` Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 13/25] hw/misc: Add Atmel power device Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 14/25] target/avr: Add section about AVR into QEMU documentation Philippe Mathieu-Daudé
2020-01-24 7:14 ` Thomas Huth
2020-01-24 11:50 ` Michael Rolnik
2020-01-24 0:51 ` [PATCH rc2 15/25] target/avr: Register AVR support with the rest of QEMU Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 16/25] target/avr: Add machine none test Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 17/25] target/avr: Update MAINTAINERS file Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 18/25] hw/core/loader: Let load_elf populate the processor-specific flags Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 19/25] hw/avr: Add helper to load raw/ELF firmware binaries Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 20/25] hw/avr: Add some ATmega microcontrollers Philippe Mathieu-Daudé
2020-01-26 14:46 ` Aleksandar Markovic
2020-01-27 7:59 ` Philippe Mathieu-Daudé
2020-01-27 8:04 ` Aleksandar Markovic
2020-01-24 0:51 ` [PATCH rc2 21/25] hw/avr: Add some Arduino boards Philippe Mathieu-Daudé
2020-01-25 9:32 ` Joaquin de Andres
2020-01-24 0:51 ` [PATCH rc2 22/25] target/avr: Update build system Philippe Mathieu-Daudé
2020-01-24 10:59 ` Alex Bennée
2020-01-24 0:51 ` [PATCH rc2 23/25] tests/boot-serial-test: Test some Arduino boards (AVR based) Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 24/25] tests/acceptance: Test the Arduino MEGA2560 board Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 25/25] .travis.yml: Run the AVR acceptance tests Philippe Mathieu-Daudé
2020-01-24 1:02 ` [PATCH rc2 00/25] target/avr merger Philippe Mathieu-Daudé
2020-01-24 7:12 ` Thomas Huth
2020-01-24 11:41 ` Michael Rolnik
2020-01-24 12:49 ` Philippe Mathieu-Daudé
2020-01-24 14:11 ` Michael Rolnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75c4ac1f-e5cb-1f6c-92d8-2cf5bb0ebea6@redhat.com \
--to=thuth@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=S.E.Harris@kent.ac.uk \
--cc=aleksandar.m.mail@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=dovgaluk@ispras.ru \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=imammedo@redhat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=me@xcancerberox.com.ar \
--cc=mrolnik@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).