From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, peter.maydell@linaro.org
Subject: Re: [PATCH v2 26/36] target/arm: Hoist the allocation of ARMCPRegInfo
Date: Thu, 25 Sep 2025 13:13:03 +0200 [thread overview]
Message-ID: <75c4b581-26e6-4e55-a589-883fab71ab6b@linaro.org> (raw)
In-Reply-To: <20250916142238.664316-27-richard.henderson@linaro.org>
On 16/9/25 16:22, Richard Henderson wrote:
> Pass in a newly allocated structure, rather than having to
> dance around allocation of the name and the structure.
>
> Since we no longer have two copies of the structure handy
> within add_cpreg_to_hashtable, delay the writeback of concrete
> values over wildcards until we're done querying the wildcards.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/helper.c | 97 ++++++++++++++++++++++-----------------------
> 1 file changed, 48 insertions(+), 49 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-09-25 11:14 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 14:22 [PATCH v2 00/36] target/arm: Reorg VHE redirection Richard Henderson
2025-09-16 14:22 ` [PATCH v2 01/36] target/arm: Introduce KVMID_AA64_SYS_REG64 Richard Henderson
2025-09-23 10:40 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 02/36] target/arm: Move compare_u64 to helper.c Richard Henderson
2025-09-23 10:39 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 03/36] target/arm/hvf: Split out sysreg.c.inc Richard Henderson
2025-09-23 10:38 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 04/36] target/arm/hvf: Reorder DEF_SYSREG arguments Richard Henderson
2025-09-23 10:38 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 05/36] target/arm/hvf: Add KVMID_TO_HVF, HVF_TO_KVMID Richard Henderson
2025-09-23 10:39 ` Philippe Mathieu-Daudé
2025-09-25 10:31 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 06/36] target/arm/hvf: Remove hvf_sreg_match.key Richard Henderson
2025-09-25 10:31 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 07/36] target/arm/hvf: Replace hvf_sreg_match with hvf_sreg_list Richard Henderson
2025-09-25 10:32 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 08/36] target/arm/hvf: Sort the cpreg_indexes array Richard Henderson
2025-09-25 10:33 ` Philippe Mathieu-Daudé
2025-09-25 13:23 ` Peter Maydell
2025-09-25 13:38 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 09/36] target/arm/hvf: Use raw_read, raw_write to access Richard Henderson
2025-09-25 10:35 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 10/36] target/arm: Use raw_write in cp_reg_reset Richard Henderson
2025-09-25 10:36 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 11/36] target/arm: Rename all ARMCPRegInfo from opaque to ri Richard Henderson
2025-09-23 10:31 ` Philippe Mathieu-Daudé
2025-09-25 10:36 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 12/36] target/arm: Drop define_one_arm_cp_reg_with_opaque Richard Henderson
2025-09-23 10:44 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 13/36] target/arm: Restrict the scope of CPREG_FIELD32, CPREG_FIELD64 Richard Henderson
2025-09-23 10:37 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 14/36] target/arm: Replace cpreg_field_is_64bit with cpreg_field_type Richard Henderson
2025-09-25 10:37 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 15/36] target/arm: Add CP_REG_AA32_64BIT_{SHIFT,MASK} Richard Henderson
2025-09-25 10:38 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 16/36] target/arm: Rename CP_REG_AA32_NS_{SHIFT,MASK} Richard Henderson
2025-09-25 10:39 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 17/36] target/arm: Convert init_cpreg_list to g_hash_table_foreach Richard Henderson
2025-09-25 10:43 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 18/36] target/arm: Remove cp argument to ENCODE_AA64_CP_REG Richard Henderson
2025-09-25 10:45 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 19/36] target/arm: Reorder ENCODE_AA64_CP_REG arguments Richard Henderson
2025-09-23 10:47 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 20/36] target/arm: Split out add_cpreg_to_hashtable_aa{32, 64} Richard Henderson
2025-09-25 10:55 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 21/36] target/arm: Improve asserts in define_one_arm_cp_reg Richard Henderson
2025-09-25 10:59 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 22/36] target/arm: Move cp processing to define_one_arm_cp_reg Richard Henderson
2025-09-25 11:00 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 23/36] target/arm: Move cpreg elimination " Richard Henderson
2025-09-25 13:27 ` Philippe Mathieu-Daudé
2025-09-25 13:44 ` Peter Maydell
2025-09-16 14:22 ` [PATCH v2 24/36] target/arm: Add key parameter to add_cpreg_to_hashtable Richard Henderson
2025-09-25 11:07 ` Philippe Mathieu-Daudé
2025-09-25 14:51 ` Peter Maydell
2025-09-25 15:54 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 25/36] target/arm: Split out alloc_cpreg Richard Henderson
2025-09-25 11:09 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 26/36] target/arm: Hoist the allocation of ARMCPRegInfo Richard Henderson
2025-09-25 11:13 ` Philippe Mathieu-Daudé [this message]
2025-09-16 14:22 ` [PATCH v2 27/36] target/arm: Remove name argument to alloc_cpreg Richard Henderson
2025-09-25 11:15 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 28/36] target/arm: Move alias setting for wildcards Richard Henderson
2025-09-25 11:40 ` Philippe Mathieu-Daudé
2025-09-25 14:55 ` Peter Maydell
2025-09-16 14:22 ` [PATCH v2 29/36] target/arm: Move writeback of CP_ANY fields Richard Henderson
2025-09-25 11:43 ` Philippe Mathieu-Daudé
2025-09-25 11:43 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 30/36] target/arm: Move endianness fixup for 32-bit registers Richard Henderson
2025-09-25 11:49 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 31/36] target/arm: Rename TBFLAG_A64_NV2_MEM_E20 with *_E2H Richard Henderson
2025-09-25 11:29 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 32/36] target/arm: Split out redirect_cpreg Richard Henderson
2025-09-25 11:30 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 33/36] target/arm: Redirect VHE FOO_EL1 -> FOO_EL2 during translation Richard Henderson
2025-09-25 13:27 ` Philippe Mathieu-Daudé
2025-09-25 13:54 ` Peter Maydell
2025-09-25 14:10 ` Peter Maydell
2025-09-16 14:22 ` [PATCH v2 34/36] target/arm: Redirect VHE FOO_EL12 to FOO_EL1 " Richard Henderson
2025-09-25 13:27 ` Philippe Mathieu-Daudé
2025-09-25 14:27 ` Peter Maydell
2025-09-16 14:22 ` [PATCH v2 35/36] target/arm: Rename some cpreg to their aarch64 names Richard Henderson
2025-09-25 11:32 ` Philippe Mathieu-Daudé
2025-09-16 14:22 ` [PATCH v2 36/36] target/arm: Remove define_arm_vh_e2h_redirects_aliases Richard Henderson
2025-09-25 13:27 ` Philippe Mathieu-Daudé
2025-09-25 14:37 ` Peter Maydell
2025-09-25 15:10 ` [PATCH v2 00/36] target/arm: Reorg VHE redirection Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75c4b581-26e6-4e55-a589-883fab71ab6b@linaro.org \
--to=philmd@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).