From: David Woodhouse <dwmw2@infradead.org>
To: paul@xen.org, qemu-devel <qemu-devel@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Subject: Re: [RFC PATCH post-8.1] hw/xen: Clean up event channel 'type_val' handling to use union
Date: Wed, 23 Aug 2023 13:09:02 +0100 [thread overview]
Message-ID: <75c5b1ad9e1195f17bcf568f1f664154cbbb3a23.camel@infradead.org> (raw)
In-Reply-To: <23529a16-3a7e-287a-4da8-eebf53d5a95d@xen.org>
[-- Attachment #1: Type: text/plain, Size: 594 bytes --]
On Mon, 2023-08-14 at 13:31 +0100, Paul Durrant wrote:
>
> > + uint16_t pirq;
> > + uint16_t virq;
> > + struct {
> > + uint16_t port:15;
> > + uint16_t to_qemu:1; /* Only two targets; qemu or loopback */
>
> I'd have switch the sense and called this 'loopback'... since it's the
> more unlikely case.
Meh, got half way through doing that and remembered why I didn't do it
the first time. It's not binary-compatible with serialized state from
before, which used the flag in 1<<15 manually.
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]
prev parent reply other threads:[~2023-08-23 12:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 15:28 [RFC PATCH post-8.1] hw/xen: Clean up event channel 'type_val' handling to use union David Woodhouse
2023-08-14 12:31 ` Paul Durrant
2023-08-23 12:09 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75c5b1ad9e1195f17bcf568f1f664154cbbb3a23.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).