From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55441)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lvivier@redhat.com>) id 1bAfrz-0005dj-Oz
	for qemu-devel@nongnu.org; Wed, 08 Jun 2016 11:58:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lvivier@redhat.com>) id 1bAfrt-0004Ws-S3
	for qemu-devel@nongnu.org; Wed, 08 Jun 2016 11:58:14 -0400
References: <1465398683-3152-1-git-send-email-thuth@redhat.com>
From: Laurent Vivier <lvivier@redhat.com>
Message-ID: <75cb4d01-7089-9d36-aaf8-948e67dce0b0@redhat.com>
Date: Wed, 8 Jun 2016 17:58:05 +0200
MIME-Version: 1.0
In-Reply-To: <1465398683-3152-1-git-send-email-thuth@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] configure: Remove unused
 CONFIG_ZERO_MALLOC setting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Huth <thuth@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org



On 08/06/2016 17:11, Thomas Huth wrote:
> CONFIG_ZERO_MALLOC was only used in qemu-malloc.c and
> this file has been removed with the following commit:
> 
> 	41a748265f4879b52b0e87ff9c93bed975163886
> 	Remove qemu_malloc/qemu_free
> 
> So we don't need this configuration setting anymore.
> This patch also removes the z_version variable, since
> this is now also not needed anymore.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Laurent Vivier <lvivier@redhat.com>

> ---
>  configure | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/configure b/configure
> index 4627d2c..316297b 100755
> --- a/configure
> +++ b/configure
> @@ -270,7 +270,6 @@ aix="no"
>  blobs="yes"
>  pkgversion=""
>  pie=""
> -zero_malloc=""
>  qom_cast_debug="yes"
>  trace_backends="log"
>  trace_file="trace"
> @@ -1389,8 +1388,6 @@ fi
>  
>  # Consult white-list to determine whether to enable werror
>  # by default.  Only enable by default for git builds
> -z_version=$(cut -f3 -d. $source_path/VERSION)
> -
>  if test -z "$werror" ; then
>      if test -d "$source_path/.git" -a \
>          "$linux" = "yes" ; then
> @@ -4575,16 +4572,6 @@ if test "$libnfs" != "no" ; then
>    fi
>  fi
>  
> -# Disable zero malloc errors for official releases unless explicitly told to
> -# enable/disable
> -if test -z "$zero_malloc" ; then
> -    if test "$z_version" = "50" ; then
> -	zero_malloc="no"
> -    else
> -	zero_malloc="yes"
> -    fi
> -fi
> -
>  # Now we've finished running tests it's OK to add -Werror to the compiler flags
>  if test "$werror" = "yes"; then
>      QEMU_CFLAGS="-Werror $QEMU_CFLAGS"
> @@ -5346,9 +5333,6 @@ if [ "$bsd" = "yes" ] ; then
>    echo "CONFIG_BSD=y" >> $config_host_mak
>  fi
>  
> -if test "$zero_malloc" = "yes" ; then
> -  echo "CONFIG_ZERO_MALLOC=y" >> $config_host_mak
> -fi
>  if test "$localtime_r" = "yes" ; then
>    echo "CONFIG_LOCALTIME_R=y" >> $config_host_mak
>  fi
>