From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B421EC61DD8 for ; Fri, 13 Nov 2020 16:22:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38BAD22226 for ; Fri, 13 Nov 2020 16:22:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GzGP+AHZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38BAD22226 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdbpv-0000Du-Bg for qemu-devel@archiver.kernel.org; Fri, 13 Nov 2020 11:22:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdbpB-0007uT-Ti for qemu-devel@nongnu.org; Fri, 13 Nov 2020 11:21:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:28030) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kdbp8-0000ws-Vy for qemu-devel@nongnu.org; Fri, 13 Nov 2020 11:21:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605284476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lyUmcL1C+UPYAYVJHjDpC7/6W9kJMLcDWRni9BqT/AE=; b=GzGP+AHZppjTDCsdh3Q6DvqiJCeraxV1qmzeNc5obuYCHupKSzqIItulvVJi2zPzFWfoBj Qx+L/v7MKXYKyyq9N/H+1ZpGYdkehOhwrRmqX9FBNtueYfgkkNmTfVSa2IQEbU9Z6hXYyM 2Jz+ahLjarhvOfK5IKgBLfxlXV+Q7xM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-470-l6IYHCvKNqOdR_GMGvYjxg-1; Fri, 13 Nov 2020 11:21:14 -0500 X-MC-Unique: l6IYHCvKNqOdR_GMGvYjxg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B97118030A0; Fri, 13 Nov 2020 16:21:13 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-114-96.ams2.redhat.com [10.36.114.96]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2DC1910013BD; Fri, 13 Nov 2020 16:21:03 +0000 (UTC) Subject: Re: [PATCH v7 19/21] simplebench/results_to_text: add difference line to the table To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org References: <20201021145859.11201-1-vsementsov@virtuozzo.com> <20201021145859.11201-20-vsementsov@virtuozzo.com> From: Max Reitz Message-ID: <75d35b7a-c1d1-947b-04bc-3f8b3b8efb0b@redhat.com> Date: Fri, 13 Nov 2020 17:21:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201021145859.11201-20-vsementsov@virtuozzo.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/12 16:09:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, kwolf@redhat.com, den@virtuozzo.com, qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote: > Performance improvements / degradations are usually discussed in > percentage. Let's make the script calculate it for us. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > scripts/simplebench/results_to_text.py | 67 +++++++++++++++++++++++--- > 1 file changed, 60 insertions(+), 7 deletions(-) > > diff --git a/scripts/simplebench/results_to_text.py b/scripts/simplebench/results_to_text.py > index 479f7ac1d4..56fdacf7ca 100644 > --- a/scripts/simplebench/results_to_text.py > +++ b/scripts/simplebench/results_to_text.py [...] > + for j in range(0, i): > + env_j = results['envs'][j] > + res_j = case_results[env_j['id']] > + cell += ' ' > + > + if 'average' not in res_j: > + # Failed result > + cell += '--' > + continue > + > + col_j = tab[0][j + 1] if named_columns else '' > + diff_pr = round((res['average'] - res_j['average']) / > + res_j['average'] * 100) > + cell += f' {col_j}{diff_pr:+}%' Contrasting to v6, you added the "cell += ' '" line, dropped a space in the "cell += '--'" line (was: "cell += ' --'"), but kept the space here. I would have assumed that the leading space is dropped here, too. But I don’t quite know, what I should be expecting, so. Anyway, I’ll just leave this here: Reviewed-by: Max Reitz > + row.append(cell) > + tab.append(row) > + > + return f'All results are in {dim}\n\n' + tabulate.tabulate(tab) >