From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, famz@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 01/17] aio: introduce aio_co_schedule and aio_co_wake
Date: Mon, 30 Jan 2017 15:15:51 -0500 [thread overview]
Message-ID: <75db602a-4cbe-f75b-9001-2949a99da341@redhat.com> (raw)
In-Reply-To: <20170130151859.GL2118@stefanha-x1.localdomain>
On 30/01/2017 10:18, Stefan Hajnoczi wrote:
> On Fri, Jan 20, 2017 at 05:43:06PM +0100, Paolo Bonzini wrote:
>> diff --git a/include/qemu/coroutine_int.h b/include/qemu/coroutine_int.h
>> index 14d4f1d..1efa356 100644
>> --- a/include/qemu/coroutine_int.h
>> +++ b/include/qemu/coroutine_int.h
>> @@ -40,12 +40,20 @@ struct Coroutine {
>> CoroutineEntry *entry;
>> void *entry_arg;
>> Coroutine *caller;
>> +
>> + /* Only used when the coroutine has terminated. */
>> QSLIST_ENTRY(Coroutine) pool_next;
>> size_t locks_held;
>
> locks_held is used when the coroutine is running. Please add a newline
> to separate it from pool_next.
>
>>
>> - /* Coroutines that should be woken up when we yield or terminate */
>> + /* Coroutines that should be woken up when we yield or terminate.
>> + * Only used when the coroutine is running.
>> + */
>> QSIMPLEQ_HEAD(, Coroutine) co_queue_wakeup;
>> +
>> + /* Only used when the coroutine is sleeping. */
>
> "running", "yielded", and "terminated" are terms with specific meanings.
> Is "sleeping" a subset of "yielded" where the coroutine is waiting for a
> mutex or its AioContext to schedule it?
No, I'll just change it to "has yielded".
>> +static void test_multi_co_schedule_entry(void *opaque)
>
> Missing coroutine_fn.
>
>> diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
>> index d2f529b..cb87997 100644
>> --- a/tests/test-vmstate.c
>> +++ b/tests/test-vmstate.c
>> @@ -33,17 +33,6 @@
>> static char temp_file[] = "/tmp/vmst.test.XXXXXX";
>> static int temp_fd;
>>
>> -/* Fake yield_until_fd_readable() implementation so we don't have to pull the
>> - * coroutine code as dependency.
>> - */
>> -void yield_until_fd_readable(int fd)
>> -{
>> - fd_set fds;
>> - FD_ZERO(&fds);
>> - FD_SET(fd, &fds);
>> - select(fd + 1, &fds, NULL, NULL, NULL);
>> -}
>> -
>>
>> /* Duplicate temp_fd and seek to the beginning of the file */
>> static QEMUFile *open_test_file(bool write)
>
> This should be a separate patch.
Yes, it probably doesn't have to be in this series either.
Paolo
next prev parent reply other threads:[~2017-01-30 20:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 16:43 [Qemu-devel] [PATCH 00/17] aio_context_acquire/release pushdown, part 2 Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 01/17] aio: introduce aio_co_schedule and aio_co_wake Paolo Bonzini
2017-01-30 15:18 ` Stefan Hajnoczi
2017-01-30 20:15 ` Paolo Bonzini [this message]
2017-01-20 16:43 ` [Qemu-devel] [PATCH 02/17] block-backend: allow blk_prw from coroutine context Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 03/17] test-thread-pool: use generic AioContext infrastructure Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 04/17] block: move AioContext and QEMUTimer to libqemuutil Paolo Bonzini
2017-01-24 9:34 ` Daniel P. Berrange
2017-01-30 15:24 ` Stefan Hajnoczi
2017-01-20 16:43 ` [Qemu-devel] [PATCH 05/17] io: add methods to set I/O handlers on AioContext Paolo Bonzini
2017-01-24 9:35 ` Daniel P. Berrange
2017-01-30 15:32 ` Stefan Hajnoczi
2017-01-20 16:43 ` [Qemu-devel] [PATCH 06/17] io: make qio_channel_yield aware of AioContexts Paolo Bonzini
2017-01-24 9:36 ` Daniel P. Berrange
2017-01-24 9:38 ` Paolo Bonzini
2017-01-24 9:40 ` Daniel P. Berrange
2017-01-30 15:37 ` Stefan Hajnoczi
2017-01-20 16:43 ` [Qemu-devel] [PATCH 07/17] nbd: convert to use qio_channel_yield Paolo Bonzini
2017-01-30 15:50 ` Stefan Hajnoczi
2017-01-30 21:18 ` Paolo Bonzini
2017-01-31 13:50 ` Stefan Hajnoczi
2017-01-31 14:29 ` Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 08/17] coroutine-lock: reschedule coroutine on the AioContext it was running on Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 09/17] qed: introduce qed_aio_start_io and qed_aio_next_io_cb Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 10/17] aio: push aio_context_acquire/release down to dispatching Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 11/17] block: explicitly acquire aiocontext in timers that need it Paolo Bonzini
2017-01-30 16:01 ` Stefan Hajnoczi
2017-01-20 16:43 ` [Qemu-devel] [PATCH 12/17] block: explicitly acquire aiocontext in callbacks " Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 13/17] block: explicitly acquire aiocontext in bottom halves " Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 14/17] block: explicitly acquire aiocontext in aio callbacks " Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 15/17] aio-posix: partially inline aio_dispatch into aio_poll Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 16/17] async: remove unnecessary inc/dec pairs Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 17/17] block: document fields protected by AioContext lock Paolo Bonzini
2017-01-24 9:38 ` [Qemu-devel] [PATCH 00/17] aio_context_acquire/release pushdown, part 2 Daniel P. Berrange
2017-01-29 20:48 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75db602a-4cbe-f75b-9001-2949a99da341@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).