From: WANG Xuerui <i.qemu@xen0n.name>
To: Richard Henderson <richard.henderson@linaro.org>,
Song Gao <gaosong@loongson.cn>,
qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, thuth@redhat.com,
chenhuacai@loongson.cn, philmd@redhat.com,
yangxiaojuan@loongson.cn, peterx@redhat.com, laurent@vivier.eu,
alistair.francis@wdc.com, maobibo@loongson.cn,
pbonzini@redhat.com, bmeng.cn@gmail.com, alex.bennee@linaro.org,
f4bug@amsat.org
Subject: Re: [PATCH v7 16/21] target/loongarch: Add disassembler
Date: Tue, 19 Oct 2021 02:18:05 +0800 [thread overview]
Message-ID: <75f4be9c-47b7-415f-4468-093b74130481@xen0n.name> (raw)
In-Reply-To: <9ba04d0a-44bb-1ebd-31f4-35c282842b4a@linaro.org>
On 10/19/21 01:29, Richard Henderson wrote:
> On 10/18/21 8:38 AM, WANG Xuerui wrote:
>>
>> For now any implementation would suffice, and I already saw one or
>> two bugs in the output during my TCG host work, but it surely would
>> be nice to switch to generated decoder in the future. The
>> loongarch-opcodes tables could be extended to support peculiarities
>> as exhibited in the v1.00 ISA manual and binutils implementation, via
>> additional attributes, and I'm open to such contributions.
>
> Perhaps it would be easiest to re-use the decodetree description?
> See e.g. target/openrisc/disas.c.
>
Indeed; I didn't thought of disassemblers in target/ instead of disas/.
That would be the most elegant way forward!
>
> r~
>
next prev parent reply other threads:[~2021-10-18 18:26 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 12:47 [PATCH v7 00/21] Add LoongArch linux-user emulation support Song Gao
2021-10-18 12:47 ` [PATCH v7 01/21] target/loongarch: Add README Song Gao
2021-10-18 12:47 ` [PATCH v7 02/21] target/loongarch: Add core definition Song Gao
2021-10-18 16:06 ` WANG Xuerui
2021-10-18 17:38 ` Philippe Mathieu-Daudé
2021-10-20 8:54 ` Song Gao
2021-10-20 12:00 ` WANG Xuerui
2021-10-20 13:56 ` Richard Henderson
2021-10-21 3:21 ` Song Gao
2021-10-21 4:10 ` WANG Xuerui
2021-10-22 0:12 ` Bob Proulx
2021-10-22 2:04 ` yangxiaojuan
2021-10-18 12:47 ` [PATCH v7 03/21] target/loongarch: Add main translation routines Song Gao
2021-10-18 12:58 ` Philippe Mathieu-Daudé
2021-10-18 12:47 ` [PATCH v7 04/21] target/loongarch: Add fixed point arithmetic instruction translation Song Gao
2021-10-18 12:47 ` [PATCH v7 05/21] target/loongarch: Add fixed point shift " Song Gao
2021-10-18 12:47 ` [PATCH v7 06/21] target/loongarch: Add fixed point bit " Song Gao
2021-10-18 12:47 ` [PATCH v7 07/21] target/loongarch: Add fixed point load/store " Song Gao
2021-10-18 12:47 ` [PATCH v7 08/21] target/loongarch: Add fixed point atomic " Song Gao
2021-10-18 12:47 ` [PATCH v7 09/21] target/loongarch: Add fixed point extra " Song Gao
2021-10-18 12:47 ` [PATCH v7 10/21] target/loongarch: Add floating point arithmetic " Song Gao
2021-10-18 12:47 ` [PATCH v7 11/21] target/loongarch: Add floating point comparison " Song Gao
2021-10-18 12:47 ` [PATCH v7 12/21] target/loongarch: Add floating point conversion " Song Gao
2021-10-18 12:47 ` [PATCH v7 13/21] target/loongarch: Add floating point move " Song Gao
2021-10-18 12:47 ` [PATCH v7 14/21] target/loongarch: Add floating point load/store " Song Gao
2021-10-18 12:47 ` [PATCH v7 15/21] target/loongarch: Add branch " Song Gao
2021-10-18 12:47 ` [PATCH v7 16/21] target/loongarch: Add disassembler Song Gao
2021-10-18 15:38 ` WANG Xuerui
2021-10-18 17:29 ` Richard Henderson
2021-10-18 18:18 ` WANG Xuerui [this message]
2021-10-18 18:33 ` Richard Henderson
2021-10-18 18:57 ` Philippe Mathieu-Daudé
2021-10-20 6:37 ` Song Gao
2021-10-18 12:47 ` [PATCH v7 17/21] LoongArch Linux User Emulation Song Gao
2021-10-18 15:22 ` WANG Xuerui
2021-10-18 12:47 ` [PATCH v7 18/21] default-configs: Add loongarch linux-user support Song Gao
2021-10-18 12:47 ` [PATCH v7 19/21] target/loongarch: Add target build suport Song Gao
2021-10-18 12:47 ` [PATCH v7 20/21] target/loongarch: 'make check-tcg' support Song Gao
2021-10-18 12:47 ` [PATCH v7 21/21] scripts: add loongarch64 binfmt config Song Gao
2021-10-18 15:49 ` WANG Xuerui
2021-10-21 6:24 ` Song Gao
2021-10-21 7:45 ` WANG Xuerui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75f4be9c-47b7-415f-4468-093b74130481@xen0n.name \
--to=i.qemu@xen0n.name \
--cc=alex.bennee@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=bmeng.cn@gmail.com \
--cc=chenhuacai@loongson.cn \
--cc=f4bug@amsat.org \
--cc=gaosong@loongson.cn \
--cc=laurent@vivier.eu \
--cc=maobibo@loongson.cn \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=yangxiaojuan@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).