From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02FF5C02199 for ; Fri, 7 Feb 2025 16:03:36 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tgQoP-0000TR-1Y; Fri, 07 Feb 2025 11:02:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgQoF-0000QH-Jg for qemu-devel@nongnu.org; Fri, 07 Feb 2025 11:02:27 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgQoD-0007G4-M4 for qemu-devel@nongnu.org; Fri, 07 Feb 2025 11:02:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738944144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nYmDv7aMaGjQaZMAV2X7qgjajETu0BznXuUVEYnnqMw=; b=URTWMTb3cES4RtB/q2qQDtp7WAz44awO8McLzdcG5jPYLBJ4JM81AlWSHPRVNeIC+oepNC uzDzievYm1frH4kgLEHQnb8QMbXKhODoYtbaODO1U+PGFNfxkKQi69UKN7grS5Sc28a/3/ nn4kY5TeKMg89jHyIkNsx8C3Ewj2wtA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-28-vGW0yefeO2CbRp_hVyvVNw-1; Fri, 07 Feb 2025 11:02:21 -0500 X-MC-Unique: vGW0yefeO2CbRp_hVyvVNw-1 X-Mimecast-MFC-AGG-ID: vGW0yefeO2CbRp_hVyvVNw Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43631d8d9c7so11855005e9.1 for ; Fri, 07 Feb 2025 08:02:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738944140; x=1739548940; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nYmDv7aMaGjQaZMAV2X7qgjajETu0BznXuUVEYnnqMw=; b=DQV32SdGkMWpbrBTo0YX9K1JSNvq+WnXwtCToH2dENh4y+qPes+IRyRMCIgsWW4qqB fldC1ATRPd8Jxl4jYm4W2AiaYIw4H+aJugq4vlFMPE19W6af7pQhmvv6wWOwqAhvM52O W4jHbBqRlE0H/ThmFaz26/vJInw8pfJ/Sab5Xz9ASsW1H17xoQDtLxLZYhJhOO2k3ZnJ RH4SMFPKxVdlND+w8Rea24qlG+H5g48BluHFprVF9VeY8XoEKzif+rkO3j5exNTT7K7Z F6RQeko6KijopMyNc/T2ytOM9HK4/Lgykaxkmc2D1/sb6SeeAuDoUK7LvP1b+A7ciG1q aQeg== X-Forwarded-Encrypted: i=1; AJvYcCULZkB7Sspm/+MTY684KL8hEr8u1imUqibVfNsRHngA5DVj33mChnl4rgcojwdq4lvjIteRNFtkunAc@nongnu.org X-Gm-Message-State: AOJu0Yxg3utki58scmSeorrPg9eN444IyRK0LIQ2dtb9A+4yPr0ytiSV ZxGwnmC98LrNx2PINqnLNEDmecV0oCpByHasUe0E9kWvV4KRYK04o26w6NIGJ1vQoqgAJqGZk0x qfdXFQxTh4Rv4+VAKJug49Ol891IwimrGBicLcvcrFYuZcMJDmSYE X-Gm-Gg: ASbGnctakXWahoeEvy9R/F+B7Ls6baa0TsaHsZx0LBD8W6/d9uKfu93POvywH5OYkMP C7rnfsrJHMlsdnPVmabh2VJYqNq6sLYUv07v+Lm6XCJ3j2UP2G5LSYBlOvhWGjMeSwZd7ehSbR9 Ri+Rmh0bg4nQpuwbJ99+EjOMYRsvJiry4glJvXvFNU8VL2DvU98k75+pM4X2otWgLV/1UTxsQ5l pcnFz7J2x420W4lPBOJ+EuGCHJVcWrIyP6T3c/rXb2KB+5bOPTkrPQS4IBe7//OKoKxQcjUBqra ZylzuLyXOxScyaaVyIzTbgq/ExZ5OpgDq2K3 X-Received: by 2002:a05:600c:198a:b0:436:1af3:5b13 with SMTP id 5b1f17b1804b1-43912d49c3amr65700135e9.15.1738944140036; Fri, 07 Feb 2025 08:02:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IEPNKYqpqSev2PKeajI3uh5KtnlpQGvb1jhoV/TfPJa8J4oXLNMORLSS+7dvgrHtgXKIkmfJQ== X-Received: by 2002:a05:600c:198a:b0:436:1af3:5b13 with SMTP id 5b1f17b1804b1-43912d49c3amr65699565e9.15.1738944139545; Fri, 07 Feb 2025 08:02:19 -0800 (PST) Received: from [192.168.0.7] (ip-109-42-48-132.web.vodafone.de. [109.42.48.132]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4391da9648dsm61317795e9.7.2025.02.07.08.02.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Feb 2025 08:02:18 -0800 (PST) Message-ID: <75f73a61-b89b-4c17-b72f-35a027049d5e@redhat.com> Date: Fri, 7 Feb 2025 17:02:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/17] tests/qtest: don't attempt to clock_step while waiting for virtio ISR To: =?UTF-8?Q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Cc: Peter Xu , Weiwei Li , qemu-arm@nongnu.org, Nicholas Piggin , Liu Zhiwei , Bin Meng , Tyrone Ting , Hao Wu , Kyle Evans , Alistair Francis , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Laurent Vivier , Riku Voipio , Harsh Prateek Bora , Fabiano Rosas , Alexandre Iooss , Laurent Vivier , Daniel Henrique Barboza , Warner Losh , Pierrick Bouvier , Palmer Dabbelt , Mahmoud Mandour , qemu-ppc@nongnu.org, Paolo Bonzini , qemu-rust@nongnu.org, qemu-riscv@nongnu.org References: <20250207153112.3939799-1-alex.bennee@linaro.org> <20250207153112.3939799-3-alex.bennee@linaro.org> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20250207153112.3939799-3-alex.bennee@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 07/02/2025 16.30, Alex Bennée wrote: > This replicates the changes from 92cb8f8bf6 (tests/qtest: remove > clock_steps from virtio tests) as there are no timers in the virtio > code. We still busy wait and timeout though. > > Signed-off-by: Alex Bennée > > --- > v2 > - fix trailing space > --- > tests/qtest/libqos/virtio-pci-modern.c | 6 ++---- > tests/qtest/libqos/virtio-pci.c | 6 ++---- > 2 files changed, 4 insertions(+), 8 deletions(-) I wonder whether a usleep(10000) in the loop might help to avoid burning too much CPU time in there? Anyway, Reviewed-by: Thomas Huth