From: Thomas Huth <thuth@redhat.com>
To: Laurent Vivier <laurent@vivier.eu>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>,
Michael Tokarev <mjt@tls.msk.ru>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PULL 00/15] Trivial branch for 5.2 patches
Date: Tue, 13 Oct 2020 13:47:13 +0200 [thread overview]
Message-ID: <76083919-fdef-de5d-128c-0099b8978175@redhat.com> (raw)
In-Reply-To: <b27a2faa-15d0-fe28-a758-537e5fdeb94c@vivier.eu>
On 13/10/2020 13.40, Laurent Vivier wrote:
> Le 13/10/2020 à 13:34, Thomas Huth a écrit :
>> On 13/10/2020 13.06, Peter Maydell wrote:
>>> On Tue, 13 Oct 2020 at 07:56, Laurent Vivier <laurent@vivier.eu> wrote:
>>>>
>>>> The following changes since commit 2387df497b4b4bcf754eb7398edca82889e2ef54:
>>>>
>>>> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-10-10' int=
>>>> o staging (2020-10-12 11:29:42 +0100)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>> git://github.com/vivier/qemu.git tags/trivial-branch-for-5.2-pull-request
>>>>
>>>> for you to fetch changes up to ef3a1d9fc36140f8933fbced70ee21fd9740b33c:
>>>>
>>>> meson.build: drop duplicate 'sparc64' entry (2020-10-12 23:11:32 +0200)
>>>>
>>>> ----------------------------------------------------------------
>>>> Trivial Patches Pull request 20201013
>>>>
>>>> ----------------------------------------------------------------
>>>
>>> Compile failure on ppc64be:
>>>
>>> ../../hw/rtc/twl92230.c: In function ‘menelaus_rx’:
>>> ../../hw/rtc/twl92230.c:289:23: error: array subscript is above array
>>> bounds [-Werror=array-bounds]
>>> return s->dcdc[addr - MENELAUS_VCORE_CTRL1];
>>
>> Uh, oh, mea culpa, copy-n-paste error... that should have been
>> MENELAUS_DCDC_CTRL1 instead.
>> Laurent, could you fix it up, or shall I send a v2 of the patch?
>
> I prefere a v2, I don't like to play with patches in a pull request.
Sure, I'll send a v2 when I've got some spare time (i.e. for a future pull
request, not for this one).
Thomas
prev parent reply other threads:[~2020-10-13 11:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 6:52 [PULL 00/15] Trivial branch for 5.2 patches Laurent Vivier
2020-10-13 6:52 ` [PULL 01/15] qemu-img-cmds.hx: Update comment that mentions Texinfo Laurent Vivier
2020-10-13 6:53 ` [PULL 02/15] target/i386/cpu: " Laurent Vivier
2020-10-13 6:53 ` [PULL 03/15] hw/rtc/twl92230: Silence warnings about missing fallthrough statements Laurent Vivier
2020-10-13 6:53 ` [PULL 04/15] hw/block/nvme: Simplify timestamp sum Laurent Vivier
2020-10-13 6:53 ` [PULL 05/15] tests/test-char: Use a proper fallthrough comment Laurent Vivier
2020-10-13 6:53 ` [PULL 06/15] vmdk: fix maybe uninitialized warnings Laurent Vivier
2020-10-13 6:53 ` [PULL 07/15] hw/acpi/piix4: Rename piix4_pm_add_propeties() to piix4_pm_add_properties() Laurent Vivier
2020-10-13 6:53 ` [PULL 08/15] softmmu/memory: Log invalid memory accesses Laurent Vivier
2020-10-13 6:53 ` [PULL 09/15] hw/pci: Fix typo in PCI hot-plug error message Laurent Vivier
2020-10-13 6:53 ` [PULL 10/15] block/blkdebug: fix memory leak Laurent Vivier
2020-10-13 6:53 ` [PULL 11/15] hw/char/serial: remove duplicate .class_init in serial_mm_info Laurent Vivier
2020-10-13 6:53 ` [PULL 12/15] goldfish_rtc: change MemoryRegionOps endianness to DEVICE_NATIVE_ENDIAN Laurent Vivier
2020-10-13 6:53 ` [PULL 13/15] target/sparc/int32_helper: Remove duplicated 'Tag Overflow' entry Laurent Vivier
2020-10-13 6:53 ` [PULL 14/15] mingw: fix error __USE_MINGW_ANSI_STDIO redefined Laurent Vivier
2020-10-13 6:53 ` [PULL 15/15] meson.build: drop duplicate 'sparc64' entry Laurent Vivier
2020-10-13 11:06 ` [PULL 00/15] Trivial branch for 5.2 patches Peter Maydell
2020-10-13 11:32 ` Laurent Vivier
2020-10-13 11:34 ` Thomas Huth
2020-10-13 11:40 ` Laurent Vivier
2020-10-13 11:47 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76083919-fdef-de5d-128c-0099b8978175@redhat.com \
--to=thuth@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).