From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 4/7] qed: make bdrv_qed_do_open a coroutine_fn
Date: Thu, 1 Feb 2018 09:48:03 -0500 [thread overview]
Message-ID: <760cf253-96ea-2244-c7de-7e123ceb92eb@redhat.com> (raw)
In-Reply-To: <76f78388-fb2a-4e39-29a1-338da45b0c32@redhat.com>
On 18/01/2018 15:19, Eric Blake wrote:
> On 01/18/2018 06:43 AM, Paolo Bonzini wrote:
>> It is called from qcow2_invalidate_cache in coroutine context (incoming
> Why is a qcow2 function calling qed code? Definitely a copy-paste bug,
> but I'm not sure of the right fix.
This reference was of course meant to be qed_invalidate_cache.
Thanks,
Paolo
>> migration runs in a coroutine), so it's cleaner if metadata is always
>> loaded from a coroutine.
next prev parent reply other threads:[~2018-02-01 14:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 12:43 [Qemu-devel] [PATCH v3 0/7] Call check and invalidate_cache from coroutine context Paolo Bonzini
2018-01-18 12:43 ` [Qemu-devel] [PATCH 1/7] block: rename .bdrv_create() to .bdrv_co_create_opts() Paolo Bonzini
2018-01-18 12:43 ` [Qemu-devel] [PATCH 2/7] qcow2: make qcow2_co_create2() a coroutine_fn Paolo Bonzini
2018-01-18 12:43 ` [Qemu-devel] [PATCH 3/7] qcow2: make qcow2_do_open " Paolo Bonzini
2018-01-18 12:43 ` [Qemu-devel] [PATCH 4/7] qed: make bdrv_qed_do_open " Paolo Bonzini
2018-01-18 20:19 ` Eric Blake
2018-02-01 14:48 ` Paolo Bonzini [this message]
2018-01-18 12:43 ` [Qemu-devel] [PATCH 5/7] block: convert bdrv_invalidate_cache callback to coroutine_fn Paolo Bonzini
2018-03-15 13:21 ` Andreas Schwab
2018-01-18 12:43 ` [Qemu-devel] [PATCH 6/7] qcow2: introduce qcow2_write_caches and qcow2_flush_caches Paolo Bonzini
2018-01-18 12:43 ` [Qemu-devel] [PATCH 7/7] block: convert bdrv_check callback to coroutine_fn Paolo Bonzini
2018-01-18 20:25 ` [Qemu-devel] [PATCH v3 0/7] Call check and invalidate_cache from coroutine context Eric Blake
2018-02-01 14:48 ` Paolo Bonzini
2018-02-26 16:49 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=760cf253-96ea-2244-c7de-7e123ceb92eb@redhat.com \
--to=pbonzini@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).