From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K5NQB-0002en-68 for qemu-devel@nongnu.org; Sun, 08 Jun 2008 12:07:07 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K5NQ9-0002be-Lu for qemu-devel@nongnu.org; Sun, 08 Jun 2008 12:07:06 -0400 Received: from [199.232.76.173] (port=55057 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K5NQ9-0002bO-7q for qemu-devel@nongnu.org; Sun, 08 Jun 2008 12:07:05 -0400 Received: from rv-out-0708.google.com ([209.85.198.251]:18958) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K5NQ8-00005B-QY for qemu-devel@nongnu.org; Sun, 08 Jun 2008 12:07:05 -0400 Received: by rv-out-0708.google.com with SMTP id f25so1610796rvb.22 for ; Sun, 08 Jun 2008 09:07:04 -0700 (PDT) Message-ID: <761ea48b0806080907t311f83dbo7f181746920baecb@mail.gmail.com> Date: Sun, 8 Jun 2008 18:07:03 +0200 From: "Laurent Desnogues" Subject: Re: [Qemu-devel] Buggy wfi support for ARM user In-Reply-To: <200806081512.36543.paul@codesourcery.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_14633_3786705.1212941223932" References: <761ea48b0806080554x4b8ca2e9o6b279fae72c357e9@mail.gmail.com> <200806081512.36543.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org ------=_Part_14633_3786705.1212941223932 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> I propose that for user mode this instruction be considered >> as a NOP. Any thoughts? > > Allowing usermode to issue WFI sounds like a bug. Here is a proposal that makes WFI no-ops for user mode emulation. Comments welcome, especially as I am not used to send patches :) Laurent ------=_Part_14633_3786705.1212941223932 Content-Type: text/x-patch; name=wfi.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_fh7tqmxv0 Content-Disposition: attachment; filename=wfi.patch ZGlmZiAtcnUgLXggLnN2biB0cnVuay9jb25maWctaG9zdC5tYWsgZWRpdC9jb25maWctaG9zdC5t YWsKLS0tIHRydW5rL2NvbmZpZy1ob3N0Lm1hawkyMDA4LTA2LTA4IDE0OjQ3OjMzLjAwMDAwMDAw MCArMDIwMAorKysgZWRpdC9jb25maWctaG9zdC5tYWsJMjAwOC0wNi0wOCAxNzozOToyNC4wMDAw MDAwMDAgKzAyMDAKQEAgLTI3LDcgKzI3LDcgQEAKIENPTkZJR19WTkNfVExTX0NGTEFHUz0gCiBD T05GSUdfVk5DX1RMU19MSUJTPS1sZ251dGxzICAKIFZFUlNJT049MC45LjEKLVNSQ19QQVRIPS9o b21lL2xkZXNub2d1L3dvcmsvRW11L3FlbXUvdHJ1bmsKK1NSQ19QQVRIPS9ob21lL2xkZXNub2d1 L3dvcmsvRW11L3FlbXUvZWRpdAogVEFSR0VUX0RJUlM9YXJtLWxpbnV4LXVzZXIKIENPTkZJR19T REw9eWVzCiBTRExfTElCUz0tTC91c3IvbGliNjQgLWxTREwgLWxwdGhyZWFkCmRpZmYgLXJ1IC14 IC5zdm4gdHJ1bmsvdGFyZ2V0LWFybS9oZWxwZXJzLmggZWRpdC90YXJnZXQtYXJtL2hlbHBlcnMu aAotLS0gdHJ1bmsvdGFyZ2V0LWFybS9oZWxwZXJzLmgJMjAwOC0wNC0xNyAyMzoxMDoyMS4wMDAw MDAwMDAgKzAyMDAKKysrIGVkaXQvdGFyZ2V0LWFybS9oZWxwZXJzLmgJMjAwOC0wNi0wOCAxNzo1 MToyMy4wMDAwMDAwMDAgKzAyMDAKQEAgLTEyMiw3ICsxMjIsOSBAQAogCiBERUZfSEVMUEVSXzFf MyhzZWxfZmxhZ3MsIHVpbnQzMl90LCAodWludDMyX3QsIHVpbnQzMl90LCB1aW50MzJfdCkpCiBE RUZfSEVMUEVSXzBfMShleGNlcHRpb24sIHZvaWQsICh1aW50MzJfdCkpCisjaWZuZGVmIENPTkZJ R19VU0VSX09OTFkKIERFRl9IRUxQRVJfMF8wKHdmaSwgdm9pZCwgKHZvaWQpKQorI2VuZGlmCiAK IERFRl9IRUxQRVJfMF8yKGNwc3Jfd3JpdGUsIHZvaWQsICh1aW50MzJfdCwgdWludDMyX3QpKQog REVGX0hFTFBFUl8xXzAoY3Bzcl9yZWFkLCB1aW50MzJfdCwgKHZvaWQpKQpkaWZmIC1ydSAteCAu c3ZuIHRydW5rL3RhcmdldC1hcm0vb3BfaGVscGVyLmMgZWRpdC90YXJnZXQtYXJtL29wX2hlbHBl ci5jCi0tLSB0cnVuay90YXJnZXQtYXJtL29wX2hlbHBlci5jCTIwMDgtMDYtMDEgMTI6Mjk6MTcu MDAwMDAwMDAwICswMjAwCisrKyBlZGl0L3RhcmdldC1hcm0vb3BfaGVscGVyLmMJMjAwOC0wNi0w OCAxNzo1MDo1NS4wMDAwMDAwMDAgKzAyMDAKQEAgLTI0NywxMiArMjQ3LDE0IEBACiAgICAgcmV0 dXJuIHJlczsKIH0KIAorI2lmbmRlZiBDT05GSUdfVVNFUl9PTkxZCiB2b2lkIEhFTFBFUih3Zmkp KHZvaWQpCiB7CiAgICAgZW52LT5leGNlcHRpb25faW5kZXggPSBFWENQX0hMVDsKICAgICBlbnYt PmhhbHRlZCA9IDE7CiAgICAgY3B1X2xvb3BfZXhpdCgpOwogfQorI2VuZGlmCiAKIHZvaWQgSEVM UEVSKGV4Y2VwdGlvbikodWludDMyX3QgZXhjcCkKIHsKZGlmZiAtcnUgLXggLnN2biB0cnVuay90 YXJnZXQtYXJtL3RyYW5zbGF0ZS5jIGVkaXQvdGFyZ2V0LWFybS90cmFuc2xhdGUuYwotLS0gdHJ1 bmsvdGFyZ2V0LWFybS90cmFuc2xhdGUuYwkyMDA4LTA2LTA3IDEzOjU5OjExLjAwMDAwMDAwMCAr MDIwMAorKysgZWRpdC90YXJnZXQtYXJtL3RyYW5zbGF0ZS5jCTIwMDgtMDYtMDggMTc6NTA6MDku MDAwMDAwMDAwICswMjAwCkBAIC02OSw3ICs2OSwxMCBAQAogCiAvKiBUaGVzZSBpbnN0cnVjdGlv bnMgdHJhcCBhZnRlciBleGVjdXRpbmcsIHNvIGRlZmVyIHRoZW0gdW50aWwgYWZ0ZXIgdGhlCiAg ICBjb25kaXRpb25hbCBleGVjdXRpb25zIHN0YXRlIGhhcyBiZWVuIHVwZGF0ZWQuICAqLworLyog Zm9yIHVzZXIgbW9kZSBob3N0ZWQgZW11bGF0aW9uIHdmaSBpcyB0cmVhdGVkIGFzIGEgbm8tb3Ag Ki8KKyNpZm5kZWYgQ09ORklHX1VTRVJfT05MWQogI2RlZmluZSBESVNBU19XRkkgNAorI2VuZGlm CiAjZGVmaW5lIERJU0FTX1NXSSA1CiAKIC8qIFhYWDogbW92ZSB0aGF0IGVsc2V3aGVyZSAqLwpA QCAtMjYxOSw4ICsyNjIyLDEyIEBACiAgICAgaWYgKChpbnNuICYgMHgwZmZmMGZmZikgPT0gMHgw ZTA3MGY5MAogICAgICAgICB8fCAoaW5zbiAmIDB4MGZmZjBmZmYpID09IDB4MGUwNzBmNTgpIHsK ICAgICAgICAgLyogV2FpdCBmb3IgaW50ZXJydXB0LiAgKi8KKyAgICAgICAgLyogZm9yIHVzZXIg bW9kZSBob3N0ZWQgZW11bGF0aW9uIHdmaSBpcyB0cmVhdGVkIGFzIGEgbm8tb3AgKi8KKyAgICAg ICAgLyogRklYTUU6ICBmb3IgQVJNdjcgdGhpcyBzaG91bGQgYWx3YXlzIGJlIGEgbm8tb3AgKi8K KyNpZm5kZWYgQ09ORklHX1VTRVJfT05MWQogICAgICAgICBnZW5fc2V0X3BjX2ltKHMtPnBjKTsK ICAgICAgICAgcy0+aXNfam1wID0gRElTQVNfV0ZJOworI2VuZGlmCiAgICAgICAgIHJldHVybiAw OwogICAgIH0KICAgICByZCA9IChpbnNuID4+IDEyKSAmIDB4ZjsKQEAgLTM0OTksOCArMzUwNiwx MSBAQAogewogICAgIHN3aXRjaCAodmFsKSB7CiAgICAgY2FzZSAzOiAvKiB3ZmkgKi8KKyAgICAg ICAgLyogZm9yIHVzZXIgbW9kZSBob3N0ZWQgZW11bGF0aW9uIHdmaSBpcyB0cmVhdGVkIGFzIGEg bm8tb3AgKi8KKyNpZm5kZWYgQ09ORklHX1VTRVJfT05MWQogICAgICAgICBnZW5fc2V0X3BjX2lt KHMtPnBjKTsKICAgICAgICAgcy0+aXNfam1wID0gRElTQVNfV0ZJOworI2VuZGlmCiAgICAgICAg IGJyZWFrOwogICAgIGNhc2UgMjogLyogd2ZlICovCiAgICAgY2FzZSA0OiAvKiBzZXYgKi8KQEAg LTg3MTIsOSArODcyMiwxMSBAQAogICAgICAgICBjYXNlIERJU0FTX1RCX0pVTVA6CiAgICAgICAg ICAgICAvKiBub3RoaW5nIG1vcmUgdG8gZ2VuZXJhdGUgKi8KICAgICAgICAgICAgIGJyZWFrOwor I2lmbmRlZiBDT05GSUdfVVNFUl9PTkxZCiAgICAgICAgIGNhc2UgRElTQVNfV0ZJOgogICAgICAg ICAgICAgZ2VuX2hlbHBlcl93ZmkoKTsKICAgICAgICAgICAgIGJyZWFrOworI2VuZGlmCiAgICAg ICAgIGNhc2UgRElTQVNfU1dJOgogICAgICAgICAgICAgZ2VuX2V4Y2VwdGlvbihFWENQX1NXSSk7 CiAgICAgICAgICAgICBicmVhazsK ------=_Part_14633_3786705.1212941223932--