qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH][ARM] Fix wrong destination register for smuad, smusd, smlad, smlsd
Date: Mon, 23 Jun 2008 11:40:29 +0200	[thread overview]
Message-ID: <761ea48b0806230240h31745caaj24e9c6f9ce80eea2@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 91 bytes --]

smuad, smusd, smlad, smlsd write the wrong register, resulting in
PC corruption.


Laurent

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: arm-smuad.patch --]
[-- Type: text/x-patch; name=arm-smuad.patch, Size: 494 bytes --]

--- svn-ref/target-arm/translate.c	2008-06-09 08:52:48.000000000 +0200
+++ svn/target-arm/translate.c	2008-06-23 11:25:40.000000000 +0200
@@ -6508,7 +6508,7 @@
                                 gen_helper_add_setq(tmp, tmp, tmp2);
                                 dead_tmp(tmp2);
                               }
-                            store_reg(s, rd, tmp);
+                            store_reg(s, rn, tmp);
                         }
                     }
                     break;

             reply	other threads:[~2008-06-23  9:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-23  9:40 Laurent Desnogues [this message]
2008-06-25 15:25 ` [Qemu-devel] Re: [PATCH][ARM] Fix wrong destination register for smuad, smusd, smlad, smlsd Laurent Desnogues
2008-06-25 16:58   ` Paul Brook
2008-06-25 17:15     ` Laurent Desnogues
2008-06-25 17:27       ` Paul Brook
2008-06-25 19:00         ` Laurent Desnogues
2008-06-25 19:11         ` Vincent Palatin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=761ea48b0806230240h31745caaj24e9c6f9ce80eea2@mail.gmail.com \
    --to=laurent.desnogues@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).