[Qemu-devel] Re: [PATCH][ARM] Fix wrong destination register for smuad, smusd, smlad, smlsd

["Laurent Desnogues" <laurent.desnogues@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

2008/6/23 Laurent Desnogues <laurent.desnogues@gmail.com>:
> smuad, smusd, smlad, smlsd write the wrong register, resulting in
> PC corruption.

Here is a better patch.

I will stop posting patches as I have the feeling the maintainer
doesn't care.  He might be rewriting everything and so my
patches are useless and a waste of time for everyone :-)

Laurent

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: arm-smuad-2.patch --]
[-- Type: text/x-patch; name=arm-smuad-2.patch, Size: 887 bytes --]

--- svn-ref/target-arm/translate.c	2008-06-09 08:52:48.000000000 +0200
+++ svn/target-arm/translate.c	2008-06-25 17:20:54.000000000 +0200
@@ -6502,13 +6502,13 @@
                             gen_storeq_reg(s, rn, rd, tmp2);
                         } else {
                             /* smuad, smusd, smlad, smlsd */
-                            if (rn != 15)
+                            if (rd != 15)
                               {
-                                tmp2 = load_reg(s, rn);
+                                tmp2 = load_reg(s, rd);
                                 gen_helper_add_setq(tmp, tmp, tmp2);
                                 dead_tmp(tmp2);
                               }
-                            store_reg(s, rd, tmp);
+                            store_reg(s, rn, tmp);
                         }
                     }
                     break;