From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KBaEY-0001sH-4I for qemu-devel@nongnu.org; Wed, 25 Jun 2008 15:00:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KBaEW-0001rM-JN for qemu-devel@nongnu.org; Wed, 25 Jun 2008 15:00:45 -0400 Received: from [199.232.76.173] (port=48696 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KBaEV-0001rH-VS for qemu-devel@nongnu.org; Wed, 25 Jun 2008 15:00:44 -0400 Received: from rv-out-0708.google.com ([209.85.198.247]:24038) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KBaEV-0000BA-HE for qemu-devel@nongnu.org; Wed, 25 Jun 2008 15:00:43 -0400 Received: by rv-out-0708.google.com with SMTP id f25so7831127rvb.22 for ; Wed, 25 Jun 2008 12:00:42 -0700 (PDT) Message-ID: <761ea48b0806251200y350f569dy9b1ea9089bb67b41@mail.gmail.com> Date: Wed, 25 Jun 2008 21:00:42 +0200 From: "Laurent Desnogues" Subject: Re: [Qemu-devel] Re: [PATCH][ARM] Fix wrong destination register for smuad, smusd, smlad, smlsd In-Reply-To: <200806251827.37618.paul@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <761ea48b0806230240h31745caaj24e9c6f9ce80eea2@mail.gmail.com> <200806251758.58313.paul@codesourcery.com> <761ea48b0806251015t4088f674hcacbc256b7a6dc0f@mail.gmail.com> <200806251827.37618.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org On Wed, Jun 25, 2008 at 7:27 PM, Paul Brook wrote: >> Anyway, are you interested in a patch that corrects enough of >> v6 instructions that FFmpeg for ARMv6 works? Would FFmpeg >> be considered as a good enough test? > > I'm generally more interested in the description/explanation of the patches > themselves. Saying "FOO works" is nice, but not as nice as convincing me > that you understand both the code you're changing, the arm architecture, and > that the two agree :-) That looks fair :-) I will submit a patch tomorrow. Is that acceptable to submit as a single patch with some text describing all the updates or should I split it instruction by instruction? Laurent