From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KCtfj-00082e-4Z
	for qemu-devel@nongnu.org; Sun, 29 Jun 2008 05:58:17 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KCtff-00081q-Tz
	for qemu-devel@nongnu.org; Sun, 29 Jun 2008 05:58:13 -0400
Received: from [199.232.76.173] (port=39235 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KCtff-00081Z-4I
	for qemu-devel@nongnu.org; Sun, 29 Jun 2008 05:58:11 -0400
Received: from rv-out-0708.google.com ([209.85.198.247]:21260)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1KCtfe-0003Dr-Od
	for qemu-devel@nongnu.org; Sun, 29 Jun 2008 05:58:10 -0400
Received: by rv-out-0708.google.com with SMTP id f25so776817rvb.22
	for <qemu-devel@nongnu.org>; Sun, 29 Jun 2008 02:58:09 -0700 (PDT)
Message-ID: <761ea48b0806290258x5eac096aj377a011a6ca028d6@mail.gmail.com>
Date: Sun, 29 Jun 2008 11:58:09 +0200
From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
Subject: Re: [Qemu-devel] [4799] Add instruction counter.
In-Reply-To: <E1KClJp-0000HC-Rt@cvs.savannah.gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <E1KClJp-0000HC-Rt@cvs.savannah.gnu.org>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sun, Jun 29, 2008 at 3:03 AM, Paul Brook <paul@nowt.org> wrote:
> Revision: 4799
>          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4799
> Author:   pbrook
> Date:     2008-06-29 01:03:05 +0000 (Sun, 29 Jun 2008)

Some trivial comments:
  - missing gen_icount.h file
  - duplicate num_insns = 0; in
target_mips/translate.c/gen_intermediate_code_internal
  - typo in vl.c/help "clock ticks per instructon"
  - typo in qemu-doc.texi under icount: "cache heirachies"


Laurent