qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] Add missing return in arm-semi
Date: Tue, 1 Jul 2008 09:25:55 +0200	[thread overview]
Message-ID: <761ea48b0807010025x716f2c37vb0c6b9fa1d11946a@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 122 bytes --]

Hello,

   there is a missing return for SYS_SYSTEM Angel semi-hosting call.
This was already sent on June 9th.


Laurent

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: arm-semi.patch --]
[-- Type: text/x-patch; name=arm-semi.patch, Size: 376 bytes --]

Index: arm-semi.c
===================================================================
--- arm-semi.c	(revision 4807)
+++ arm-semi.c	(working copy)
@@ -362,6 +362,7 @@
                 return (uint32_t)-1;
             ret = set_swi_errno(ts, system(s));
             unlock_user(s, ARG(0), 0);
+            return ret;
         }
     case SYS_ERRNO:
 #ifdef CONFIG_USER_ONLY

             reply	other threads:[~2008-07-01  7:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-01  7:25 Laurent Desnogues [this message]
2008-07-01 17:45 ` [Qemu-devel] [PATCH] Add missing return in arm-semi David Barrett
2008-07-01 17:45   ` David Barrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=761ea48b0807010025x716f2c37vb0c6b9fa1d11946a@mail.gmail.com \
    --to=laurent.desnogues@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).