[Qemu-devel] [PATCH] Add missing return in arm-semi

[Qemu-devel] [PATCH] Add missing return in arm-semi

[Laurent Desnogues]

[-- Attachment #1: Type: text/plain, Size: 122 bytes --]

Hello,

   there is a missing return for SYS_SYSTEM Angel semi-hosting call.
This was already sent on June 9th.


Laurent

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: arm-semi.patch --]
[-- Type: text/x-patch; name=arm-semi.patch, Size: 376 bytes --]

Index: arm-semi.c
===================================================================
--- arm-semi.c	(revision 4807)
+++ arm-semi.c	(working copy)
@@ -362,6 +362,7 @@
                 return (uint32_t)-1;
             ret = set_swi_errno(ts, system(s));
             unlock_user(s, ARG(0), 0);
+            return ret;
         }
     case SYS_ERRNO:
 #ifdef CONFIG_USER_ONLY

Re: [Qemu-devel] [PATCH] Add missing return in arm-semi

[David Barrett]

Ah, yes, sorry -- the letter scale arrived.  Very odd!  Do you need me 
to use it?

On Tue, 1 Jul 2008 12:25 am, Laurent Desnogues wrote:
> Hello,
>
>    there is a missing return for SYS_SYSTEM Angel semi-hosting call.
> This was already sent on June 9th.
>
>
> Laurent

Re: [Qemu-devel] [PATCH] Add missing return in arm-semi

[David Barrett]

Whoops -- please ignore.  Misaddressed.

----------

Ah, yes, sorry -- the letter scale arrived.  Very odd!  Do you need me 
to use it?

On Tue, 1 Jul 2008 12:25 am, Laurent Desnogues wrote:
> Hello,
>
>    there is a missing return for SYS_SYSTEM Angel semi-hosting call.
> This was already sent on June 9th.
>
>
> Laurent