From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KEfjk-0000Fx-JL for qemu-devel@nongnu.org; Fri, 04 Jul 2008 03:29:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KEfjj-0000FF-Ak for qemu-devel@nongnu.org; Fri, 04 Jul 2008 03:29:44 -0400 Received: from [199.232.76.173] (port=41960 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KEfjj-0000FC-2E for qemu-devel@nongnu.org; Fri, 04 Jul 2008 03:29:43 -0400 Received: from mx20.gnu.org ([199.232.41.8]:34417) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KEfji-0000mT-JO for qemu-devel@nongnu.org; Fri, 04 Jul 2008 03:29:42 -0400 Received: from rv-out-0708.google.com ([209.85.198.245]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KEfjf-0008Nr-Dv for qemu-devel@nongnu.org; Fri, 04 Jul 2008 03:29:39 -0400 Received: by rv-out-0708.google.com with SMTP id f25so1072585rvb.22 for ; Fri, 04 Jul 2008 00:29:36 -0700 (PDT) Message-ID: <761ea48b0807040029k368086e1n1525f183b49d9c81@mail.gmail.com> Date: Fri, 4 Jul 2008 09:29:36 +0200 From: "Laurent Desnogues" Subject: Re: [Qemu-devel] [4844] Avoid compiler warning. In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_15939_10365496.1215156576772" References: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org ------=_Part_15939_10365496.1215156576772 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline On Thu, Jul 3, 2008 at 11:36 PM, Thiemo Seufer wrote: > Revision: 4844 [...] > -#define h2g(x) ((target_ulong)(x - GUEST_BASE)) > +#define h2g(x) ((target_ulong)((unsigned long)(x) - GUEST_BASE)) What about getting rid of explicit casts when using h2g? Laurent ------=_Part_15939_10365496.1215156576772 Content-Type: text/x-patch; name=h2g.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_fi8gqz1z0 Content-Disposition: attachment; filename=h2g.patch SW5kZXg6IGxpbnV4LXVzZXIvc3lzY2FsbC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGxpbnV4LXVzZXIvc3lz Y2FsbC5jCShyZXZpc2lvbiA0ODQ1KQorKysgbGludXgtdXNlci9zeXNjYWxsLmMJKHdvcmtpbmcg Y29weSkKQEAgLTIwMTgsNyArMjAxOCw3IEBACiAgICAgICAgICAgICAgICAgcmV0ID0gZ2V0X2Vy cm5vKChsb25nKWhvc3RfYWRkcik7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAg ICB9Ci0gICAgICAgICAgICByYWRkciA9IGgyZygodW5zaWduZWQgbG9uZylob3N0X2FkZHIpOwor ICAgICAgICAgICAgcmFkZHIgPSBoMmcoaG9zdF9hZGRyKTsKICAgICAgICAgICAgIC8qIGZpbmQg b3V0IHRoZSBsZW5ndGggb2YgdGhlIHNoYXJlZCBtZW1vcnkgc2VnbWVudCAqLwogICAgICAgICAg ICAgCiAgICAgICAgICAgICByZXQgPSBnZXRfZXJybm8oc2htY3RsKGZpcnN0LCBJUENfU1RBVCwg JnNobV9pbmZvKSk7CkBAIC0yNDc3LDcgKzI0NzcsNyBAQAogICAgICAgICBpZiAoIWxkdF90YWJs ZSkKICAgICAgICAgICAgIHJldHVybiAtVEFSR0VUX0VOT01FTTsKICAgICAgICAgbWVtc2V0KGxk dF90YWJsZSwgMCwgVEFSR0VUX0xEVF9FTlRSSUVTICogVEFSR0VUX0xEVF9FTlRSWV9TSVpFKTsK LSAgICAgICAgZW52LT5sZHQuYmFzZSA9IGgyZygodW5zaWduZWQgbG9uZylsZHRfdGFibGUpOwor ICAgICAgICBlbnYtPmxkdC5iYXNlID0gaDJnKGxkdF90YWJsZSk7CiAgICAgICAgIGVudi0+bGR0 LmxpbWl0ID0gMHhmZmZmOwogICAgIH0KIApJbmRleDogbGludXgtdXNlci9tYWluLmMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gbGludXgtdXNlci9tYWluLmMJKHJldmlzaW9uIDQ4NDUpCisrKyBsaW51eC11c2Vy L21haW4uYwkod29ya2luZyBjb3B5KQpAQCAtMjQ3Miw3ICsyNDcyLDcgQEAKICAgICB7CiAgICAg ICAgIHVpbnQ2NF90ICpnZHRfdGFibGU7CiAgICAgICAgIGdkdF90YWJsZSA9IHFlbXVfbWFsbG9j eihzaXplb2YodWludDY0X3QpICogVEFSR0VUX0dEVF9FTlRSSUVTKTsKLSAgICAgICAgZW52LT5n ZHQuYmFzZSA9IGgyZygodW5zaWduZWQgbG9uZylnZHRfdGFibGUpOworICAgICAgICBlbnYtPmdk dC5iYXNlID0gaDJnKGdkdF90YWJsZSk7CiAgICAgICAgIGVudi0+Z2R0LmxpbWl0ID0gc2l6ZW9m KHVpbnQ2NF90KSAqIFRBUkdFVF9HRFRfRU5UUklFUyAtIDE7CiAjaWZkZWYgVEFSR0VUX0FCSTMy CiAgICAgICAgIHdyaXRlX2R0KCZnZHRfdGFibGVbX19VU0VSX0NTID4+IDNdLCAwLCAweGZmZmZm LAo= ------=_Part_15939_10365496.1215156576772--