From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KJ5JX-0006I0-Oj
	for qemu-devel@nongnu.org; Wed, 16 Jul 2008 07:36:55 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KJ5JV-0006H8-Vy
	for qemu-devel@nongnu.org; Wed, 16 Jul 2008 07:36:55 -0400
Received: from [199.232.76.173] (port=51892 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KJ5JV-0006Gx-Nq
	for qemu-devel@nongnu.org; Wed, 16 Jul 2008 07:36:53 -0400
Received: from rv-out-0708.google.com ([209.85.198.247]:23300)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1KJ5JW-0007Zf-1h
	for qemu-devel@nongnu.org; Wed, 16 Jul 2008 07:36:54 -0400
Received: by rv-out-0708.google.com with SMTP id f25so4533365rvb.22
	for <qemu-devel@nongnu.org>; Wed, 16 Jul 2008 04:36:00 -0700 (PDT)
Message-ID: <761ea48b0807160436s6fd84eb4p6982eb4660c7df04@mail.gmail.com>
Date: Wed, 16 Jul 2008 13:36:00 +0200
From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
Subject: Re: [Qemu-devel] [4875] Remove unintended dereference,
	kills a warning (Jan Kiszka).
In-Reply-To: <E1KJ5Dz-0006JQ-WD@cvs.savannah.gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <E1KJ5Dz-0006JQ-WD@cvs.savannah.gnu.org>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Wed, Jul 16, 2008 at 1:31 PM, Andrzej Zaborowski <balrogg@gmail.com> wrote:
>
> Modified: trunk/target-sh4/op.c
> ===================================================================
> --- trunk/target-sh4/op.c       2008-07-16 04:45:12 UTC (rev 4874)
> +++ trunk/target-sh4/op.c       2008-07-16 11:31:11 UTC (rev 4875)
> @@ -594,8 +594,8 @@
>
>  void OPPROTO op_tasb_rN(void)
>  {
> -    cond_t(*(int8_t *) env->gregs[PARAM1] == 0);
> -    *(int8_t *) env->gregs[PARAM1] |= 0x80;
> +    cond_t((env->gregs[PARAM1] && 0xff) == 0);

Guess that should be a single '&'.

> +    *(int8_t *) &env->gregs[PARAM1] |= 0x80;
>     RETURN();
>  }

Laurent