From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [4875] Remove unintended dereference, kills a warning (Jan Kiszka).
Date: Wed, 16 Jul 2008 14:30:08 +0200 [thread overview]
Message-ID: <761ea48b0807160530k59412f39p6ae0c90c2756fb58@mail.gmail.com> (raw)
In-Reply-To: <jeskuayqzt.fsf@sykes.suse.de>
On Wed, Jul 16, 2008 at 2:04 PM, Andreas Schwab <schwab@suse.de> wrote:
> Andrzej Zaborowski <balrogg@gmail.com> writes:
>
>> void OPPROTO op_tasb_rN(void)
>> {
>> - cond_t(*(int8_t *) env->gregs[PARAM1] == 0);
>> - *(int8_t *) env->gregs[PARAM1] |= 0x80;
>> + cond_t((env->gregs[PARAM1] && 0xff) == 0);
>> + *(int8_t *) &env->gregs[PARAM1] |= 0x80;
>
> That does not make any sense at all. The TAS insn operates on memory,
> not on a register (atomic operations only make sense on memory anyway).
SH4 documentation says this:
TAS.B @Rn
If (Rn) = 0, 1 → T, else 0 → T
1 → MSB of (Rn)
So indeed it looks like Jan and Andrzej patch is wrong.
Laurent
next prev parent reply other threads:[~2008-07-16 12:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 11:31 [Qemu-devel] [4875] Remove unintended dereference, kills a warning (Jan Kiszka) Andrzej Zaborowski
2008-07-16 11:36 ` Laurent Desnogues
2008-07-16 12:10 ` [Qemu-devel] " Jan Kiszka
2008-07-16 12:04 ` [Qemu-devel] " Andreas Schwab
2008-07-16 12:30 ` Laurent Desnogues [this message]
2008-07-16 12:35 ` [Qemu-devel] " Jan Kiszka
2008-07-19 6:24 ` andrzej zaborowski
2008-08-18 7:13 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=761ea48b0807160530k59412f39p6ae0c90c2756fb58@mail.gmail.com \
--to=laurent.desnogues@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).