From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KQeD5-0002wq-0E
	for qemu-devel@nongnu.org; Wed, 06 Aug 2008 04:17:31 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KQeD2-0002tA-5v
	for qemu-devel@nongnu.org; Wed, 06 Aug 2008 04:17:29 -0400
Received: from [199.232.76.173] (port=55649 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KQeD1-0002sl-WF
	for qemu-devel@nongnu.org; Wed, 06 Aug 2008 04:17:28 -0400
Received: from rv-out-0708.google.com ([209.85.198.251]:20575)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1KQeD1-0004WZ-JE
	for qemu-devel@nongnu.org; Wed, 06 Aug 2008 04:17:27 -0400
Received: by rv-out-0708.google.com with SMTP id f25so2342456rvb.22
	for <qemu-devel@nongnu.org>; Wed, 06 Aug 2008 01:17:26 -0700 (PDT)
Message-ID: <761ea48b0808060117k2bd2a599l662604dbd920207a@mail.gmail.com>
Date: Wed, 6 Aug 2008 10:17:26 +0200
From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
Subject: Re: [Qemu-devel] another SPARC issue
In-Reply-To: <20080805223132.C58183@stanley.csl.cornell.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20080728225136.C26546@stanley.csl.cornell.edu>
	<f43fc5580807291018n7f47d010l97276f704b5afb52@mail.gmail.com>
	<20080805161615.S57426@stanley.csl.cornell.edu>
	<761ea48b0808051336o120c3e9j286d9523a693f98f@mail.gmail.com>
	<20080805223132.C58183@stanley.csl.cornell.edu>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Wed, Aug 6, 2008 at 4:33 AM, Vince Weaver <vince@csl.cornell.edu> wrote:
>
> From what I can tell from the sparcv9 manual this patch is correct, but I
> might be missing something.
>
> --- translate.c.org     2008-08-05 22:30:15.000000000 -0400
> +++ translate.c 2008-08-05 22:30:26.000000000 -0400
> @@ -1641,13 +1641,11 @@
>  #ifdef TARGET_SPARC64
>  static inline TCGv gen_get_asi(int insn, TCGv r_addr)
>  {
> -    int asi, offset;
> +    int asi;
>     TCGv r_asi;
>
>     if (IS_IMM) {
>         r_asi = tcg_temp_new(TCG_TYPE_I32);
> -        offset = GET_FIELD(insn, 25, 31);
> -        tcg_gen_addi_tl(r_addr, r_addr, offset);
>         tcg_gen_ld_i32(r_asi, cpu_env, offsetof(CPUSPARCState, asi));
>     } else {
>         asi = GET_FIELD(insn, 19, 26);

My understanding of v9 manual is the same as yours.  Your patch looks
correct.


Laurent