From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH]: fix a nit in exec.c
Date: Fri, 29 Aug 2008 13:27:03 +0200 [thread overview]
Message-ID: <761ea48b0808290427j7e387f0auaed3e96995895cd1@mail.gmail.com> (raw)
In-Reply-To: <F42B13D1-2B40-4795-959A-43C496865E0D@adacore.com>
On Fri, Aug 22, 2008 at 3:56 PM, Tristan Gingold <gingold@adacore.com> wrote:
> Hi,
>
> the parameter of page_find_alloc is a page index and not an address.
>
> Tristan.
>
> Signed-off-by: Tristan Gingold <gingold@adacore.com>
>
> --- exec.c (revision 5062)
> +++ exec.c (working copy)
> @@ -286,7 +286,7 @@
> #if TARGET_LONG_BITS > 32
> /* Host memory outside guest VM. For 32-bit targets we have already
> excluded high addresses. */
> - if (index > ((target_ulong)L2_SIZE * L1_SIZE * TARGET_PAGE_SIZE))
> + if (index > ((target_ulong)L2_SIZE * L1_SIZE))
> return NULL;
> #endif
> lp = &l1_map[index >> L2_BITS];
This patch is correct and fixes the problem I spotted here:
http://lists.gnu.org/archive/html/qemu-devel/2008-08/msg00241.html
Is there any hope to see this committed?
Laurent
prev parent reply other threads:[~2008-08-29 11:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 13:56 [Qemu-devel] [PATCH]: fix a nit in exec.c Tristan Gingold
2008-08-29 11:27 ` Laurent Desnogues [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=761ea48b0808290427j7e387f0auaed3e96995895cd1@mail.gmail.com \
--to=laurent.desnogues@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).