[Qemu-devel] [PATCH]: fix a nit in exec.c

[Qemu-devel] [PATCH]: fix a nit in exec.c

[Tristan Gingold]

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

Hi,

the parameter of page_find_alloc is a page index and not an address.

Tristan.

Signed-off-by: Tristan Gingold <gingold@adacore.com>

--- exec.c	(revision 5062)
+++ exec.c	(working copy)
@@ -286,7 +286,7 @@
  #if TARGET_LONG_BITS > 32
      /* Host memory outside guest VM.  For 32-bit targets we have  
already
         excluded high addresses.  */
-    if (index > ((target_ulong)L2_SIZE * L1_SIZE * TARGET_PAGE_SIZE))
+    if (index > ((target_ulong)L2_SIZE * L1_SIZE))
          return NULL;
  #endif
      lp = &l1_map[index >> L2_BITS];



[-- Attachment #2: qeexec.diff --]
[-- Type: application/octet-stream, Size: 483 bytes --]

Index: exec.c
===================================================================
--- exec.c	(revision 5062)
+++ exec.c	(working copy)
@@ -286,7 +286,7 @@
 #if TARGET_LONG_BITS > 32
     /* Host memory outside guest VM.  For 32-bit targets we have already
        excluded high addresses.  */
-    if (index > ((target_ulong)L2_SIZE * L1_SIZE * TARGET_PAGE_SIZE))
+    if (index > ((target_ulong)L2_SIZE * L1_SIZE))
         return NULL;
 #endif
     lp = &l1_map[index >> L2_BITS];

Re: [Qemu-devel] [PATCH]: fix a nit in exec.c

[Laurent Desnogues]

On Fri, Aug 22, 2008 at 3:56 PM, Tristan Gingold <gingold@adacore.com> wrote:
> Hi,
>
> the parameter of page_find_alloc is a page index and not an address.
>
> Tristan.
>
> Signed-off-by: Tristan Gingold <gingold@adacore.com>
>
> --- exec.c      (revision 5062)
> +++ exec.c      (working copy)
> @@ -286,7 +286,7 @@
>  #if TARGET_LONG_BITS > 32
>     /* Host memory outside guest VM.  For 32-bit targets we have already
>        excluded high addresses.  */
> -    if (index > ((target_ulong)L2_SIZE * L1_SIZE * TARGET_PAGE_SIZE))
> +    if (index > ((target_ulong)L2_SIZE * L1_SIZE))
>         return NULL;
>  #endif
>     lp = &l1_map[index >> L2_BITS];

This patch is correct and fixes the problem I spotted here:

http://lists.gnu.org/archive/html/qemu-devel/2008-08/msg00241.html

Is there any hope to see this committed?


Laurent