From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KZ28B-0007WW-Nk
	for qemu-devel@nongnu.org; Fri, 29 Aug 2008 07:27:07 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KZ28A-0007VE-1Y
	for qemu-devel@nongnu.org; Fri, 29 Aug 2008 07:27:07 -0400
Received: from [199.232.76.173] (port=34786 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KZ289-0007Uz-Rb
	for qemu-devel@nongnu.org; Fri, 29 Aug 2008 07:27:05 -0400
Received: from rv-out-0708.google.com ([209.85.198.241]:7912)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1KZ289-00032k-H9
	for qemu-devel@nongnu.org; Fri, 29 Aug 2008 07:27:05 -0400
Received: by rv-out-0708.google.com with SMTP id f25so691247rvb.22
	for <qemu-devel@nongnu.org>; Fri, 29 Aug 2008 04:27:03 -0700 (PDT)
Message-ID: <761ea48b0808290427j7e387f0auaed3e96995895cd1@mail.gmail.com>
Date: Fri, 29 Aug 2008 13:27:03 +0200
From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
Subject: Re: [Qemu-devel] [PATCH]: fix a nit in exec.c
In-Reply-To: <F42B13D1-2B40-4795-959A-43C496865E0D@adacore.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <F42B13D1-2B40-4795-959A-43C496865E0D@adacore.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Fri, Aug 22, 2008 at 3:56 PM, Tristan Gingold <gingold@adacore.com> wrote:
> Hi,
>
> the parameter of page_find_alloc is a page index and not an address.
>
> Tristan.
>
> Signed-off-by: Tristan Gingold <gingold@adacore.com>
>
> --- exec.c      (revision 5062)
> +++ exec.c      (working copy)
> @@ -286,7 +286,7 @@
>  #if TARGET_LONG_BITS > 32
>     /* Host memory outside guest VM.  For 32-bit targets we have already
>        excluded high addresses.  */
> -    if (index > ((target_ulong)L2_SIZE * L1_SIZE * TARGET_PAGE_SIZE))
> +    if (index > ((target_ulong)L2_SIZE * L1_SIZE))
>         return NULL;
>  #endif
>     lp = &l1_map[index >> L2_BITS];

This patch is correct and fixes the problem I spotted here:

http://lists.gnu.org/archive/html/qemu-devel/2008-08/msg00241.html

Is there any hope to see this committed?


Laurent