From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] add futimesat syscall
Date: Thu, 18 Sep 2008 09:23:20 +0200 [thread overview]
Message-ID: <761ea48b0809180023t37d300ceq790fe33c5ab7602a@mail.gmail.com> (raw)
In-Reply-To: <20080918063007.GA26841@kos.to>
On Thu, Sep 18, 2008 at 8:30 AM, Riku Voipio <riku.voipio@iki.fi> wrote:
> On Thu, Sep 18, 2008 at 01:54:21AM +0200, andrzej zaborowski wrote:
>> 2008/9/17 Riku Voipio <riku.voipio@iki.fi>:
>> > Add futimes patch, originally from scratchbox qemu devkit.
>
>> Kirill Shutemov submitted an imlementation of futimensat() at
>> http://lists.gnu.org/archive/html/qemu-devel/2008-09/msg00439.html ,
>> it looks cleaner to me.
>
> Kirill's patch looks good to me.
There's a functional difference between Kirill's patch and yours:
Kirill + ret = get_errno(futimesat(arg1, p, tvp));
you + ret = get_errno(sys_futimesat(arg1, path(p), tv));
Laurent
next prev parent reply other threads:[~2008-09-18 7:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-17 19:45 [Qemu-devel] [PATCH] add futimesat syscall Riku Voipio
2008-09-17 23:54 ` andrzej zaborowski
2008-09-18 5:00 ` Kirill A. Shutemov
2008-09-18 6:30 ` Riku Voipio
2008-09-18 7:23 ` Laurent Desnogues [this message]
2008-09-18 9:08 ` Riku Voipio
2008-09-18 9:28 ` Kirill A. Shutemov
2008-09-18 9:42 ` Riku Voipio
2008-09-18 10:16 ` Kirill A. Shutemov
2008-09-18 11:13 ` Thiemo Seufer
2008-09-18 11:45 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=761ea48b0809180023t37d300ceq790fe33c5ab7602a@mail.gmail.com \
--to=laurent.desnogues@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).