From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KgDrL-0001cX-Rl
	for qemu-devel@nongnu.org; Thu, 18 Sep 2008 03:23:27 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KgDrJ-0001cL-G8
	for qemu-devel@nongnu.org; Thu, 18 Sep 2008 03:23:26 -0400
Received: from [199.232.76.173] (port=35237 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KgDrJ-0001cI-AJ
	for qemu-devel@nongnu.org; Thu, 18 Sep 2008 03:23:25 -0400
Received: from mx20.gnu.org ([199.232.41.8]:37335)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <laurent.desnogues@gmail.com>)
	id 1KgDrJ-0005QG-Il
	for qemu-devel@nongnu.org; Thu, 18 Sep 2008 03:23:25 -0400
Received: from rv-out-0708.google.com ([209.85.198.250])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1KgDrH-000229-58
	for qemu-devel@nongnu.org; Thu, 18 Sep 2008 03:23:23 -0400
Received: by rv-out-0708.google.com with SMTP id f25so3414231rvb.22
	for <qemu-devel@nongnu.org>; Thu, 18 Sep 2008 00:23:21 -0700 (PDT)
Message-ID: <761ea48b0809180023t37d300ceq790fe33c5ab7602a@mail.gmail.com>
Date: Thu, 18 Sep 2008 09:23:20 +0200
From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] add futimesat syscall
In-Reply-To: <20080918063007.GA26841@kos.to>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20080917194533.GB21187@kos.to>
	<fb249edb0809171654q374a20e2kd16453cc6faed6e7@mail.gmail.com>
	<20080918063007.GA26841@kos.to>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Thu, Sep 18, 2008 at 8:30 AM, Riku Voipio <riku.voipio@iki.fi> wrote:
> On Thu, Sep 18, 2008 at 01:54:21AM +0200, andrzej zaborowski wrote:
>> 2008/9/17 Riku Voipio <riku.voipio@iki.fi>:
>> > Add futimes patch, originally from scratchbox qemu devkit.
>
>> Kirill Shutemov submitted an imlementation of futimensat() at
>> http://lists.gnu.org/archive/html/qemu-devel/2008-09/msg00439.html ,
>> it looks cleaner to me.
>
> Kirill's patch looks good to me.

There's a functional difference between Kirill's patch and yours:

Kirill +            ret = get_errno(futimesat(arg1, p, tvp));
you   +                ret = get_errno(sys_futimesat(arg1, path(p), tv));


Laurent