From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] [resubmit] Allocate translation buffer before guest RAM, in case guest RAM is too large on 64 bit hosts
Date: Thu, 23 Oct 2008 08:31:02 +0200 [thread overview]
Message-ID: <761ea48b0810222331g2e56f4e0ocde6229ae975d5ef@mail.gmail.com> (raw)
In-Reply-To: <20081022221051.GA14534@saturn.kn-bremen.de>
On Thu, Oct 23, 2008 at 12:10 AM, Juergen Lock <nox@jelal.kn-bremen.de> wrote:
>
> Further explanation as requested: cpu_exec_init_all() below allocates
> code_gen_buffer which needs to be in the lower 4G (actually 2G I guess)
> because it uses 32 bit branch offsets. Allocate this first so that the
> guest RAM allocation can't get in the way i.e. block the lower vm when
> doing something like -m 4096 on systems that allocate from low addresses
> by default.
>
> I hope this is more clear now? :)
What about including a shorter version of that explanation as a comment
in your patch ? :)
Laurent
next prev parent reply other threads:[~2008-10-23 6:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 22:10 [Qemu-devel] [PATCH] [resubmit] Allocate translation buffer before guest RAM, in case guest RAM is too large on 64 bit hosts Juergen Lock
2008-10-23 6:31 ` Laurent Desnogues [this message]
2008-10-23 21:29 ` Juergen Lock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=761ea48b0810222331g2e56f4e0ocde6229ae975d5ef@mail.gmail.com \
--to=laurent.desnogues@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).