* [Qemu-devel] n270 SSSE3 flag problem
@ 2008-10-27 18:58 Blue Swirl
2008-10-27 19:10 ` Laurent Desnogues
2008-10-27 19:30 ` [Qemu-devel] " andrzej zaborowski
0 siblings, 2 replies; 3+ messages in thread
From: Blue Swirl @ 2008-10-27 18:58 UTC (permalink / raw)
To: andrzej zaborowski, qemu-devel@nongnu.org
Hi,
Sparse detected a problem with n270 CPU definition, I think
.ext_features = CPUID_EXT_MONITOR |
CPUID_EXT_SSE3 /* PNI */, CPUID_EXT_SSSE3,
/* Missing: CPUID_EXT_DSCPL | CPUID_EXT_EST |
* CPUID_EXT_TM2 | CPUID_EXT_XTPR */
should be:
.ext_features = CPUID_EXT_MONITOR |
CPUID_EXT_SSE3 /* PNI */ | CPUID_EXT_SSSE3,
/* Missing: CPUID_EXT_DSCPL | CPUID_EXT_EST |
* CPUID_EXT_TM2 | CPUID_EXT_XTPR */
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] n270 SSSE3 flag problem
2008-10-27 18:58 [Qemu-devel] n270 SSSE3 flag problem Blue Swirl
@ 2008-10-27 19:10 ` Laurent Desnogues
2008-10-27 19:30 ` [Qemu-devel] " andrzej zaborowski
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Desnogues @ 2008-10-27 19:10 UTC (permalink / raw)
To: qemu-devel
On Mon, Oct 27, 2008 at 7:58 PM, Blue Swirl <blauwirbel@gmail.com> wrote:
>
> Sparse detected a problem with n270 CPU definition, I think
> .ext_features = CPUID_EXT_MONITOR |
> CPUID_EXT_SSE3 /* PNI */, CPUID_EXT_SSSE3,
> /* Missing: CPUID_EXT_DSCPL | CPUID_EXT_EST |
> * CPUID_EXT_TM2 | CPUID_EXT_XTPR */
> should be:
> .ext_features = CPUID_EXT_MONITOR |
> CPUID_EXT_SSE3 /* PNI */ | CPUID_EXT_SSSE3,
> /* Missing: CPUID_EXT_DSCPL | CPUID_EXT_EST |
> * CPUID_EXT_TM2 | CPUID_EXT_XTPR */
SSSE3 is indeed supported by n270 according to Intel documentation
http://download.intel.com/design/processor/datashts/320032.pdf
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] Re: n270 SSSE3 flag problem
2008-10-27 18:58 [Qemu-devel] n270 SSSE3 flag problem Blue Swirl
2008-10-27 19:10 ` Laurent Desnogues
@ 2008-10-27 19:30 ` andrzej zaborowski
1 sibling, 0 replies; 3+ messages in thread
From: andrzej zaborowski @ 2008-10-27 19:30 UTC (permalink / raw)
To: Blue Swirl; +Cc: qemu-devel@nongnu.org
2008/10/27 Blue Swirl <blauwirbel@gmail.com>:
> Hi,
>
> Sparse detected a problem with n270 CPU definition, I think
> .ext_features = CPUID_EXT_MONITOR |
> CPUID_EXT_SSE3 /* PNI */, CPUID_EXT_SSSE3,
> /* Missing: CPUID_EXT_DSCPL | CPUID_EXT_EST |
> * CPUID_EXT_TM2 | CPUID_EXT_XTPR */
> should be:
> .ext_features = CPUID_EXT_MONITOR |
> CPUID_EXT_SSE3 /* PNI */ | CPUID_EXT_SSSE3,
> /* Missing: CPUID_EXT_DSCPL | CPUID_EXT_EST |
> * CPUID_EXT_TM2 | CPUID_EXT_XTPR */
Thanks, good catch! I had only tested n270 in user mode, that's why
it didn't blow up.
Cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-27 19:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-27 18:58 [Qemu-devel] n270 SSSE3 flag problem Blue Swirl
2008-10-27 19:10 ` Laurent Desnogues
2008-10-27 19:30 ` [Qemu-devel] " andrzej zaborowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).