qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] User qemu profiling
Date: Wed, 29 Oct 2008 10:28:14 +0100	[thread overview]
Message-ID: <761ea48b0810290228i6ad068b1maa9cd4ea325ab691@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

Hello,

this patch:

  - Makefile.target:  re-enable profiling for user qemu.  It seems
    profiling was (accidently?) removed by commit 3937

  - syscall.c:
      * add an include to get _mcleanup prototype
      * add a call to _mcleanup for exit_group in a way
        similar to what is done for exit

BTW, I wonder why -p is preferred over -pg for profiling.

Thanks,

Laurent

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: user-profile.patch --]
[-- Type: text/x-patch; name=user-profile.patch, Size: 1032 bytes --]

Index: Makefile.target
===================================================================
--- Makefile.target	(revision 5545)
+++ Makefile.target	(working copy)
@@ -394,6 +394,12 @@
 endif
 endif
 
+# profiling code
+ifdef TARGET_GPROF
+LDFLAGS+=-p
+CFLAGS+=-p
+endif
+
 OBJS= main.o syscall.o strace.o mmap.o signal.o path.o thunk.o \
       elfload.o linuxload.o uaccess.o
 LIBS+= $(AIOLIBS)
Index: linux-user/syscall.c
===================================================================
--- linux-user/syscall.c	(revision 5566)
+++ linux-user/syscall.c	(working copy)
@@ -54,6 +54,9 @@
 #include <netinet/ip.h>
 #include <netinet/tcp.h>
 #include <qemu-common.h>
+#ifdef HAVE_GPROF
+#include <sys/gmon.h>
+#endif
 
 #define termios host_termios
 #define winsize host_winsize
@@ -4864,6 +4867,9 @@
 #ifdef __NR_exit_group
         /* new thread calls */
     case TARGET_NR_exit_group:
+#ifdef HAVE_GPROF
+        _mcleanup();
+#endif
         gdb_exit(cpu_env, arg1);
         ret = get_errno(exit_group(arg1));
         break;

             reply	other threads:[~2008-10-29  9:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29  9:28 Laurent Desnogues [this message]
2008-11-06 16:16 ` [Qemu-devel] [PATCH] User qemu profiling Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=761ea48b0810290228i6ad068b1maa9cd4ea325ab691@mail.gmail.com \
    --to=laurent.desnogues@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).