From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH, RFT] Update i386-dis.c from binutils 2.17
Date: Thu, 30 Oct 2008 12:03:47 +0100 [thread overview]
Message-ID: <761ea48b0810300403l24e65c3fy97b45ee0fd3a3c37@mail.gmail.com> (raw)
In-Reply-To: <f43fc5580810271129n1344d692x8088e1b297e6ec3d@mail.gmail.com>
On Mon, Oct 27, 2008 at 7:29 PM, Blue Swirl <blauwirbel@gmail.com> wrote:
>
> This very lightly tested patch updates i386-dis.c from binutils 2.17.
> If someone can test it more thoroughly and declare that the patch is
> useful and it does not break anything, I may apply it.
I made a quick run on x86_64 and the only difference in the trace
was the replacement of:
mov %rdx,(%r12)
to:
mov %rdx,(%r12,1)
I guess the extra 1 is a scaling factor that was previously omitted
(and which might be needed to distinguish two instructions that
have different object code).
Of course, my test doesn't mean the patch broke nothing, but it's
better than no test :-)
Laurent
prev parent reply other threads:[~2008-10-30 11:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 18:29 [Qemu-devel] [PATCH, RFT] Update i386-dis.c from binutils 2.17 Blue Swirl
2008-10-29 16:52 ` Laurent Desnogues
2008-10-29 17:24 ` Alexander Graf
2008-10-29 18:40 ` Blue Swirl
2008-10-30 11:03 ` Laurent Desnogues [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=761ea48b0810300403l24e65c3fy97b45ee0fd3a3c37@mail.gmail.com \
--to=laurent.desnogues@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).