From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KvVJf-0000NU-7x for qemu-devel@nongnu.org; Thu, 30 Oct 2008 07:03:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KvVJd-0000MO-Kt for qemu-devel@nongnu.org; Thu, 30 Oct 2008 07:03:50 -0400 Received: from [199.232.76.173] (port=35851 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KvVJd-0000MG-DN for qemu-devel@nongnu.org; Thu, 30 Oct 2008 07:03:49 -0400 Received: from wf-out-1314.google.com ([209.85.200.174]:30700) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KvVJc-0000JC-Pe for qemu-devel@nongnu.org; Thu, 30 Oct 2008 07:03:49 -0400 Received: by wf-out-1314.google.com with SMTP id 27so517917wfd.4 for ; Thu, 30 Oct 2008 04:03:47 -0700 (PDT) Message-ID: <761ea48b0810300403l24e65c3fy97b45ee0fd3a3c37@mail.gmail.com> Date: Thu, 30 Oct 2008 12:03:47 +0100 From: "Laurent Desnogues" Subject: Re: [Qemu-devel] [PATCH, RFT] Update i386-dis.c from binutils 2.17 In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Mon, Oct 27, 2008 at 7:29 PM, Blue Swirl wrote: > > This very lightly tested patch updates i386-dis.c from binutils 2.17. > If someone can test it more thoroughly and declare that the patch is > useful and it does not break anything, I may apply it. I made a quick run on x86_64 and the only difference in the trace was the replacement of: mov %rdx,(%r12) to: mov %rdx,(%r12,1) I guess the extra 1 is a scaling factor that was previously omitted (and which might be needed to distinguish two instructions that have different object code). Of course, my test doesn't mean the patch broke nothing, but it's better than no test :-) Laurent