qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Alpha: fix locked loads/stores
Date: Fri, 7 Nov 2008 17:42:52 +0100	[thread overview]
Message-ID: <761ea48b0811070842i264703ci255bc858be6e9ebd@mail.gmail.com> (raw)
In-Reply-To: <20081107151828.GA353@hall.aurel32.net>

On Fri, Nov 7, 2008 at 4:18 PM, Aurelien Jarno <aurelien@aurel32.net> wrote:
> The manual is actually not really clear. Section 4.2.5 does not really
> speak about storing the locked address, while Section 3.1.4 explicitly
> mentions a "locked_physical_address register".

Yes, it's really unclear.

> The current implementation, now that it is fixed (can someone confirms
> that the problem is actually fixed?), matches the pre-TCG
> implementation. I am not sure it is the correct one, but if it works for
> now and until someone comes with more arguments, I think we should let
> the code as now.

I agree.  It's probably better than simply ignoring the address.

We need a way to test the behavior on real machines with some
multi-threaded testcase.


Laurent

  reply	other threads:[~2008-11-07 16:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-07 11:34 [Qemu-devel] [PATCH] Alpha: fix locked loads/stores Laurent Desnogues
2008-11-07 14:00 ` Aurelien Jarno
2008-11-07 14:19   ` Laurent Desnogues
2008-11-07 15:18     ` Aurelien Jarno
2008-11-07 16:42       ` Laurent Desnogues [this message]
2008-11-07 17:44         ` Vince Weaver
2008-11-08  9:12           ` Aurelien Jarno
2008-11-08 14:11             ` Laurent Desnogues
2008-11-07 16:47       ` Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=761ea48b0811070842i264703ci255bc858be6e9ebd@mail.gmail.com \
    --to=laurent.desnogues@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).