qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5645] target-alpha: fix locked loads/stores
Date: Mon, 10 Nov 2008 18:18:27 +0100	[thread overview]
Message-ID: <761ea48b0811100918m61f8d608i69579147bedd60b6@mail.gmail.com> (raw)
In-Reply-To: <58BD0469C48A7443A479A13D101685E301647278@ala-mail09.corp.ad.wrs.com>

On Mon, Nov 10, 2008 at 6:07 PM, Krumme, Chris
<Chris.Krumme@windriver.com> wrote:
>
>>      TCGv addr = tcg_temp_new(TCG_TYPE_I64);
>> +    if (local)
>> +        addr = tcg_temp_local_new(TCG_TYPE_I64);
>> +    else
>> +        addr = tcg_temp_new(TCG_TYPE_I64);
>
> I don't fully understand how these things work, but for the non-local
> case you are calling tcg_temp_new twice.

You are right, the call in the declaration should be removed.


Laurent

  reply	other threads:[~2008-11-10 17:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-07 14:00 [Qemu-devel] [5645] target-alpha: fix locked loads/stores Aurelien Jarno
2008-11-10 17:07 ` Krumme, Chris
2008-11-10 17:18   ` Laurent Desnogues [this message]
2008-11-11 11:30   ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=761ea48b0811100918m61f8d608i69579147bedd60b6@mail.gmail.com \
    --to=laurent.desnogues@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).