From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KzaPI-0006yC-Js
	for qemu-devel@nongnu.org; Mon, 10 Nov 2008 12:18:32 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KzaPG-0006xB-VJ
	for qemu-devel@nongnu.org; Mon, 10 Nov 2008 12:18:32 -0500
Received: from [199.232.76.173] (port=48991 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KzaPG-0006x3-RR
	for qemu-devel@nongnu.org; Mon, 10 Nov 2008 12:18:30 -0500
Received: from wf-out-1314.google.com ([209.85.200.172]:42513)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1KzaPG-00030r-Fo
	for qemu-devel@nongnu.org; Mon, 10 Nov 2008 12:18:30 -0500
Received: by wf-out-1314.google.com with SMTP id 27so2723389wfd.4
	for <qemu-devel@nongnu.org>; Mon, 10 Nov 2008 09:18:27 -0800 (PST)
Message-ID: <761ea48b0811100918m61f8d608i69579147bedd60b6@mail.gmail.com>
Date: Mon, 10 Nov 2008 18:18:27 +0100
From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
Subject: Re: [Qemu-devel] [5645] target-alpha: fix locked loads/stores
In-Reply-To: <58BD0469C48A7443A479A13D101685E301647278@ala-mail09.corp.ad.wrs.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <E1KyRt0-0002J6-KF@cvs.savannah.gnu.org>
	<58BD0469C48A7443A479A13D101685E301647278@ala-mail09.corp.ad.wrs.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Mon, Nov 10, 2008 at 6:07 PM, Krumme, Chris
<Chris.Krumme@windriver.com> wrote:
>
>>      TCGv addr = tcg_temp_new(TCG_TYPE_I64);
>> +    if (local)
>> +        addr = tcg_temp_local_new(TCG_TYPE_I64);
>> +    else
>> +        addr = tcg_temp_new(TCG_TYPE_I64);
>
> I don't fully understand how these things work, but for the non-local
> case you are calling tcg_temp_new twice.

You are right, the call in the declaration should be removed.


Laurent