* [Qemu-devel] [PATCH] ARM: fix usad8 and usada8 instructions
@ 2008-11-25 23:27 Mans Rullgard
2008-11-26 8:05 ` Laurent Desnogues
0 siblings, 1 reply; 2+ messages in thread
From: Mans Rullgard @ 2008-11-25 23:27 UTC (permalink / raw)
To: qemu-devel
This fixes the destination and accumulator registers for the usad8
and usada8 instructions.
Signed-off-by: Mans Rullgard <mans@mansr.com>
---
target-arm/translate.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
index 186f1d5..305a438 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -6556,12 +6556,12 @@ static void disas_arm_insn(CPUState * env, DisasContext *s)
tmp2 = load_reg(s, rs);
gen_helper_usad8(tmp, tmp, tmp2);
dead_tmp(tmp2);
- if (rn != 15) {
- tmp2 = load_reg(s, rn);
+ if (rd != 15) {
+ tmp2 = load_reg(s, rd);
tcg_gen_add_i32(tmp, tmp, tmp2);
dead_tmp(tmp2);
}
- store_reg(s, rd, tmp);
+ store_reg(s, rn, tmp);
break;
case 0x20: case 0x24: case 0x28: case 0x2c:
/* Bitfield insert/clear. */
--
1.6.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] ARM: fix usad8 and usada8 instructions
2008-11-25 23:27 [Qemu-devel] [PATCH] ARM: fix usad8 and usada8 instructions Mans Rullgard
@ 2008-11-26 8:05 ` Laurent Desnogues
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Desnogues @ 2008-11-26 8:05 UTC (permalink / raw)
To: qemu-devel
On Wed, Nov 26, 2008 at 12:27 AM, Mans Rullgard <mans@mansr.com> wrote:
> This fixes the destination and accumulator registers for the usad8
> and usada8 instructions.
This patch is correct.
Is this when I should put a "acked-by"?
Laurent
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---
> target-arm/translate.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 186f1d5..305a438 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -6556,12 +6556,12 @@ static void disas_arm_insn(CPUState * env, DisasContext *s)
> tmp2 = load_reg(s, rs);
> gen_helper_usad8(tmp, tmp, tmp2);
> dead_tmp(tmp2);
> - if (rn != 15) {
> - tmp2 = load_reg(s, rn);
> + if (rd != 15) {
> + tmp2 = load_reg(s, rd);
> tcg_gen_add_i32(tmp, tmp, tmp2);
> dead_tmp(tmp2);
> }
> - store_reg(s, rd, tmp);
> + store_reg(s, rn, tmp);
> break;
> case 0x20: case 0x24: case 0x28: case 0x2c:
> /* Bitfield insert/clear. */
> --
> 1.6.0.4
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-26 8:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-25 23:27 [Qemu-devel] [PATCH] ARM: fix usad8 and usada8 instructions Mans Rullgard
2008-11-26 8:05 ` Laurent Desnogues
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).