From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L6rIs-0006eQ-48
	for qemu-devel@nongnu.org; Sun, 30 Nov 2008 13:45:58 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L6rIq-0006e3-EB
	for qemu-devel@nongnu.org; Sun, 30 Nov 2008 13:45:57 -0500
Received: from [199.232.76.173] (port=40388 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L6rIq-0006e0-A8
	for qemu-devel@nongnu.org; Sun, 30 Nov 2008 13:45:56 -0500
Received: from fg-out-1718.google.com ([72.14.220.154]:1712)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1L6rIp-0003EY-UE
	for qemu-devel@nongnu.org; Sun, 30 Nov 2008 13:45:56 -0500
Received: by fg-out-1718.google.com with SMTP id l26so1556284fgb.8
	for <qemu-devel@nongnu.org>; Sun, 30 Nov 2008 10:45:14 -0800 (PST)
Message-ID: <761ea48b0811301045g563be9ddg357d6115cd8ea26@mail.gmail.com>
Date: Sun, 30 Nov 2008 19:45:13 +0100
From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] ppc: Convert op_440_dlmzb to TCG
In-Reply-To: <0994E4E8-B10A-4449-8639-5877689A7D28@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <6044C5AC-C1B7-42AF-80F0-2254392A9F37@web.de>
	<20081130163117.GH11797@hall.aurel32.net>
	<E9E607A7-43F5-44DD-885D-B5A9FC5BF73D@web.de>
	<761ea48b0811300940i67f27e38hddb17efa242532ae@mail.gmail.com>
	<0994E4E8-B10A-4449-8639-5877689A7D28@web.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sun, Nov 30, 2008 at 7:03 PM, Andreas F=E4rber <andreas.faerber@web.de> =
wrote:
>
> So, if I encounter a dyngen op that calls a helper, then in general I sho=
uld
> convert it to TCG code calling the helper?

I guess it depends, but in most cases probably.  If an instruction is
not used often and its implementation in the old helper is rather
long or uses branches (if/else, loops), you should keep it as a
helper.

> My next problem is op_440_tlbre, which does call a helper, but with a PAR=
AM1
> argument. Any hint how to translate that?

I am not familiar at all with the old generator, so take what I say with
a grain of salt :-)

PARAM1 probably was a parameter passed at runtime.  Now with
the way helper calls are generated, you explicitly pass parameters.
Your best bet is to look at how Aur=E9lien reimplemented dlmzb or
any other complex helpers since he started the conversion to TCG.


Laurent