From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L9P1V-0004c9-0L for qemu-devel@nongnu.org; Sun, 07 Dec 2008 14:10:33 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L9P1T-0004bH-Sx for qemu-devel@nongnu.org; Sun, 07 Dec 2008 14:10:32 -0500 Received: from [199.232.76.173] (port=35440 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L9P1T-0004bB-Nw for qemu-devel@nongnu.org; Sun, 07 Dec 2008 14:10:31 -0500 Received: from fg-out-1718.google.com ([72.14.220.158]:62175) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L9P1T-0008AA-2z for qemu-devel@nongnu.org; Sun, 07 Dec 2008 14:10:31 -0500 Received: by fg-out-1718.google.com with SMTP id l26so639633fgb.8 for ; Sun, 07 Dec 2008 11:10:30 -0800 (PST) Message-ID: <761ea48b0812071110m6409f99dje1687b37ccf2f012@mail.gmail.com> Date: Sun, 7 Dec 2008 20:10:30 +0100 From: "Laurent Desnogues" Subject: Re: [Qemu-devel] [PATCH] Some cleanups after dyngen removal In-Reply-To: <20081207181721.GB19389@hall.aurel32.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_42199_28607570.1228677030219" References: <761ea48b0812070912q5a1961d9t3bbf5905238daee8@mail.gmail.com> <20081207181721.GB19389@hall.aurel32.net> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org ------=_Part_42199_28607570.1228677030219 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline On Sun, Dec 7, 2008 at 7:17 PM, Aurelien Jarno wrote: > > Yes, it is a good start. A grep -r dyngen still gives some results, but > far less. This code can be removed in another commit. It remains to rename dyngen-exec.h, some variables and functions, and change some comments. Here are some further cleanups. 1. hostregs_helper.h: fix comment 2. translate-all.c: rename dyngen_code(_search_pc) to tcg_gen_code(_search_pc) 3. tcg.c: - rename dyngen_table_op_count to tcg_table_op_count - no need to generate a log of dyngen ops generated - rename dyngen_code(_search_pc) to tcg_gen_code(_search_pc) 4. tcg.h: rename dyngen_code(_search_pc) to tcg_gen_code(_search_pc) Laurent Signed-off-by: Laurent Desnogues ------=_Part_42199_28607570.1228677030219 Content-Type: text/x-patch; name=tcg-no-dyngen2.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_fog2iaes0 Content-Disposition: attachment; filename=tcg-no-dyngen2.patch SW5kZXg6IGhvc3RyZWdzX2hlbHBlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGhvc3RyZWdzX2hlbHBlci5o CShyZXZpc2lvbiA1OTIzKQorKysgaG9zdHJlZ3NfaGVscGVyLmgJKHdvcmtpbmcgY29weSkKQEAg LTE4LDkgKzE4LDkgQEAKICAqIEZvdW5kYXRpb24sIEluYy4sIDU5IFRlbXBsZSBQbGFjZSwgU3Vp dGUgMzMwLCBCb3N0b24sIE1BICAwMjExMS0xMzA3ICBVU0EKICAqLwogCi0vKiBUaGUgR0NDIGds b2JhbCByZWdpc3RlciB2YWlyYWJsZSBleHRlbnNpb24gaXMgdXNlZCB0byByZXNlcnZlIHNvbWUK LSAgIGhvc3QgcmVnaXN0ZXJzIGZvciB1c2UgYnkgZHluZ2VuLiAgSG93ZXZlciBvbmx5IHRoZSBj b3JlIHBhcnRzIG9mIHRoZQotICAgdHJhbnNsYXRpb24gZW5naW5lIGFyZSBjb21waWxlZCB3aXRo IHRoZXNlIHNldHRpbmdzLiAgV2UgbXVzdCBtYW51YWxseQorLyogVGhlIEdDQyBnbG9iYWwgcmVn aXN0ZXIgdmFyaWFibGUgZXh0ZW5zaW9uIGlzIHVzZWQgdG8gcmVzZXJ2ZSBzb21lCisgICBob3N0 IHJlZ2lzdGVycyBmb3IgdXNlIGJ5IGdlbmVyYXRlZCBjb2RlLiAgSG93ZXZlciBvbmx5IHRoZSBj b3JlIHBhcnRzIG9mCisgICB0aGUgdHJhbnNsYXRpb24gZW5naW5lIGFyZSBjb21waWxlZCB3aXRo IHRoZXNlIHNldHRpbmdzLiAgV2UgbXVzdCBtYW51YWxseQogICAgc2F2ZS9yZXN0b3JlIHRoZXNl IHJlZ2lzdGVycyB3aGVuIGNhbGxlZCBmcm9tIHJlZ3VsYXIgY29kZS4KICAgIEl0IGlzIG5vdCBz dWZmaWNpZW50IHRvIHNhdmUvcmVzdG9yZSBUMCBldC4gYWwuIGFzIHRoZXNlIG1heSBiZSBkZWNs YXJlZAogICAgd2l0aCBhIGRhdGF0eXBlIHNtYWxsZXIgdGhhbiB0aGUgYWN0dWFsIHJlZ2lzdGVy LiAgKi8KSW5kZXg6IHRyYW5zbGF0ZS1hbGwuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB0cmFuc2xhdGUtYWxs LmMJKHJldmlzaW9uIDU5MjMpCisrKyB0cmFuc2xhdGUtYWxsLmMJKHdvcmtpbmcgY29weSkKQEAg LTExOCw3ICsxMTgsNyBAQAogICAgIHMtPmludGVybV90aW1lICs9IHByb2ZpbGVfZ2V0Y2xvY2so KSAtIHRpOwogICAgIHMtPmNvZGVfdGltZSAtPSBwcm9maWxlX2dldGNsb2NrKCk7CiAjZW5kaWYK LSAgICBnZW5fY29kZV9zaXplID0gZHluZ2VuX2NvZGUocywgZ2VuX2NvZGVfYnVmKTsKKyAgICBn ZW5fY29kZV9zaXplID0gdGNnX2dlbl9jb2RlKHMsIGdlbl9jb2RlX2J1Zik7CiAgICAgKmdlbl9j b2RlX3NpemVfcHRyID0gZ2VuX2NvZGVfc2l6ZTsKICNpZmRlZiBDT05GSUdfUFJPRklMRVIKICAg ICBzLT5jb2RlX3RpbWUgKz0gcHJvZmlsZV9nZXRjbG9jaygpOwpAQCAtMTc3LDcgKzE3Nyw3IEBA CiAgICAgcy0+dGJfam1wX29mZnNldCA9IE5VTEw7CiAgICAgcy0+dGJfbmV4dCA9IHRiLT50Yl9u ZXh0OwogI2VuZGlmCi0gICAgaiA9IGR5bmdlbl9jb2RlX3NlYXJjaF9wYyhzLCAodWludDhfdCAq KXRjX3B0ciwgc2VhcmNoZWRfcGMgLSB0Y19wdHIpOworICAgIGogPSB0Y2dfZ2VuX2NvZGVfc2Vh cmNoX3BjKHMsICh1aW50OF90ICopdGNfcHRyLCBzZWFyY2hlZF9wYyAtIHRjX3B0cik7CiAgICAg aWYgKGogPCAwKQogICAgICAgICByZXR1cm4gLTE7CiAgICAgLyogbm93IGZpbmQgc3RhcnQgb2Yg aW5zdHJ1Y3Rpb24gYmVmb3JlICovCkluZGV4OiB0Y2cvdGNnLmMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gdGNn L3RjZy5jCShyZXZpc2lvbiA1OTIzKQorKysgdGNnL3RjZy5jCSh3b3JraW5nIGNvcHkpCkBAIC0x ODkwLDIwICsxODkwLDE2IEBACiAKICNpZmRlZiBDT05GSUdfUFJPRklMRVIKIAotc3RhdGljIGlu dDY0X3QgZHluZ2VuX3RhYmxlX29wX2NvdW50W05CX09QU107CitzdGF0aWMgaW50NjRfdCB0Y2df dGFibGVfb3BfY291bnRbTkJfT1BTXTsKIAogdm9pZCBkdW1wX29wX2NvdW50KHZvaWQpCiB7CiAg ICAgaW50IGk7CiAgICAgRklMRSAqZjsKLSAgICBmID0gZm9wZW4oIi90bXAvb3AxLmxvZyIsICJ3 Iik7Ci0gICAgZm9yKGkgPSAwOyBpIDwgSU5ERVhfb3BfZW5kOyBpKyspIHsKLSAgICAgICAgZnBy aW50ZihmLCAiJXMgJSIgUFJJZDY0ICJcbiIsIHRjZ19vcF9kZWZzW2ldLm5hbWUsIGR5bmdlbl90 YWJsZV9vcF9jb3VudFtpXSk7Ci0gICAgfQogICAgIGZjbG9zZShmKTsKLSAgICBmID0gZm9wZW4o Ii90bXAvb3AyLmxvZyIsICJ3Iik7CisgICAgZiA9IGZvcGVuKCIvdG1wL29wLmxvZyIsICJ3Iik7 CiAgICAgZm9yKGkgPSBJTkRFWF9vcF9lbmQ7IGkgPCBOQl9PUFM7IGkrKykgewotICAgICAgICBm cHJpbnRmKGYsICIlcyAlIiBQUklkNjQgIlxuIiwgdGNnX29wX2RlZnNbaV0ubmFtZSwgZHluZ2Vu X3RhYmxlX29wX2NvdW50W2ldKTsKKyAgICAgICAgZnByaW50ZihmLCAiJXMgJSIgUFJJZDY0ICJc biIsIHRjZ19vcF9kZWZzW2ldLm5hbWUsIHRjZ190YWJsZV9vcF9jb3VudFtpXSk7CiAgICAgfQog ICAgIGZjbG9zZShmKTsKIH0KQEAgLTE5NTMsNyArMTk0OSw3IEBACiAgICAgZm9yKDs7KSB7CiAg ICAgICAgIG9wYyA9IGdlbl9vcGNfYnVmW29wX2luZGV4XTsKICNpZmRlZiBDT05GSUdfUFJPRklM RVIKLSAgICAgICAgZHluZ2VuX3RhYmxlX29wX2NvdW50W29wY10rKzsKKyAgICAgICAgdGNnX3Rh YmxlX29wX2NvdW50W29wY10rKzsKICNlbmRpZgogICAgICAgICBkZWYgPSAmdGNnX29wX2RlZnNb b3BjXTsKICNpZiAwCkBAIC0yMDMwLDcgKzIwMjYsNyBAQAogICAgIHJldHVybiAtMTsKIH0KIAot aW50IGR5bmdlbl9jb2RlKFRDR0NvbnRleHQgKnMsIHVpbnQ4X3QgKmdlbl9jb2RlX2J1ZikKK2lu dCB0Y2dfZ2VuX2NvZGUoVENHQ29udGV4dCAqcywgdWludDhfdCAqZ2VuX2NvZGVfYnVmKQogewog I2lmZGVmIENPTkZJR19QUk9GSUxFUgogICAgIHsKQEAgLTIwNTgsNyArMjA1NCw3IEBACiAgICBv ZmZzZXQgYnl0ZXMgZnJvbSB0aGUgc3RhcnQgb2YgdGhlIFRCLiAgVGhlIGNvbnRlbnRzIG9mIGdl bl9jb2RlX2J1ZiBtdXN0CiAgICBub3QgYmUgY2hhbmdlZCwgdGhvdWdoIHdyaXRpbmcgdGhlIHNh bWUgdmFsdWVzIGlzIG9rLgogICAgUmV0dXJuIC0xIGlmIG5vdCBmb3VuZC4gKi8KLWludCBkeW5n ZW5fY29kZV9zZWFyY2hfcGMoVENHQ29udGV4dCAqcywgdWludDhfdCAqZ2VuX2NvZGVfYnVmLCBs b25nIG9mZnNldCkKK2ludCB0Y2dfZ2VuX2NvZGVfc2VhcmNoX3BjKFRDR0NvbnRleHQgKnMsIHVp bnQ4X3QgKmdlbl9jb2RlX2J1ZiwgbG9uZyBvZmZzZXQpCiB7CiAgICAgcmV0dXJuIHRjZ19nZW5f Y29kZV9jb21tb24ocywgZ2VuX2NvZGVfYnVmLCBvZmZzZXQpOwogfQpJbmRleDogdGNnL3RjZy5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIHRjZy90Y2cuaAkocmV2aXNpb24gNTkyMykKKysrIHRjZy90Y2cuaAko d29ya2luZyBjb3B5KQpAQCAtMzE0LDggKzMxNCw4IEBACiB2b2lkIHRjZ19jb250ZXh0X2luaXQo VENHQ29udGV4dCAqcyk7CiB2b2lkIHRjZ19mdW5jX3N0YXJ0KFRDR0NvbnRleHQgKnMpOwogCi1p bnQgZHluZ2VuX2NvZGUoVENHQ29udGV4dCAqcywgdWludDhfdCAqZ2VuX2NvZGVfYnVmKTsKLWlu dCBkeW5nZW5fY29kZV9zZWFyY2hfcGMoVENHQ29udGV4dCAqcywgdWludDhfdCAqZ2VuX2NvZGVf YnVmLCBsb25nIG9mZnNldCk7CitpbnQgdGNnX2dlbl9jb2RlKFRDR0NvbnRleHQgKnMsIHVpbnQ4 X3QgKmdlbl9jb2RlX2J1Zik7CitpbnQgdGNnX2dlbl9jb2RlX3NlYXJjaF9wYyhUQ0dDb250ZXh0 ICpzLCB1aW50OF90ICpnZW5fY29kZV9idWYsIGxvbmcgb2Zmc2V0KTsKIAogdm9pZCB0Y2dfc2V0 X2ZyYW1lKFRDR0NvbnRleHQgKnMsIGludCByZWcsCiAgICAgICAgICAgICAgICAgICAgdGNnX3Rh cmdldF9sb25nIHN0YXJ0LCB0Y2dfdGFyZ2V0X2xvbmcgc2l6ZSk7Cg== ------=_Part_42199_28607570.1228677030219--