From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [sh] Don't set FD bit in user mode emulation
Date: Sat, 13 Dec 2008 01:13:26 +0100 [thread overview]
Message-ID: <761ea48b0812121613rd6d12cfm45a595137fa90c36@mail.gmail.com> (raw)
In-Reply-To: <1229126610.3898.45.camel@cocoduo.atr>
On Sat, Dec 13, 2008 at 1:03 AM, Lionel Landwerlin
<lionel.landwerlin@openwide.fr> wrote:
> static void cpu_sh4_reset(CPUSH4State * env)
> {
> #if defined(CONFIG_USER_ONLY)
> - env->sr = SR_FD; /* FD - kernel does lazy fpu context switch */
> + /* env->sr = SR_FD; */ /* FD - kernel does lazy fpu context switch */
I think it's better when commenting out code to say why it's
commented out.
However in that particular case, I would simply remove the
code: unless there's something I don't understand, I can't
see why FPU disable should be set (unless, as I said
previously, if the ELF header contains a flag stating the
program needs FPU instructions in which case this should
be handled differently).
Laurent
next prev parent reply other threads:[~2008-12-13 0:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-13 0:03 [Qemu-devel] [sh] Don't set FD bit in user mode emulation Lionel Landwerlin
2008-12-13 0:13 ` Laurent Desnogues [this message]
2008-12-13 11:15 ` takasi-y
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=761ea48b0812121613rd6d12cfm45a595137fa90c36@mail.gmail.com \
--to=laurent.desnogues@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).