From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LBI8P-0007Vr-Va
	for qemu-devel@nongnu.org; Fri, 12 Dec 2008 19:13:30 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LBI8P-0007U2-0r
	for qemu-devel@nongnu.org; Fri, 12 Dec 2008 19:13:29 -0500
Received: from [199.232.76.173] (port=54496 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LBI8O-0007Td-Px
	for qemu-devel@nongnu.org; Fri, 12 Dec 2008 19:13:28 -0500
Received: from fg-out-1718.google.com ([72.14.220.156]:45877)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1LBI8O-0006n6-7n
	for qemu-devel@nongnu.org; Fri, 12 Dec 2008 19:13:28 -0500
Received: by fg-out-1718.google.com with SMTP id l26so847538fgb.8
	for <qemu-devel@nongnu.org>; Fri, 12 Dec 2008 16:13:26 -0800 (PST)
Message-ID: <761ea48b0812121613rd6d12cfm45a595137fa90c36@mail.gmail.com>
Date: Sat, 13 Dec 2008 01:13:26 +0100
From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
Subject: Re: [Qemu-devel] [sh] Don't set FD bit in user mode emulation
In-Reply-To: <1229126610.3898.45.camel@cocoduo.atr>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1229126610.3898.45.camel@cocoduo.atr>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sat, Dec 13, 2008 at 1:03 AM, Lionel Landwerlin
<lionel.landwerlin@openwide.fr> wrote:
>  static void cpu_sh4_reset(CPUSH4State * env)
>  {
>  #if defined(CONFIG_USER_ONLY)
> -    env->sr = SR_FD;            /* FD - kernel does lazy fpu context switch */
> +    /* env->sr = SR_FD; */            /* FD - kernel does lazy fpu context switch */

I think it's better when commenting out code to say why it's
commented out.

However in that particular case, I would simply remove the
code:  unless there's something I don't understand, I can't
see why FPU disable should be set (unless, as I said
previously, if the ELF header contains a flag stating the
program needs FPU instructions in which case this should
be handled differently).


Laurent