From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LDg4L-0000t7-Sw
	for qemu-devel@nongnu.org; Fri, 19 Dec 2008 09:11:09 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LDg4L-0000rX-2i
	for qemu-devel@nongnu.org; Fri, 19 Dec 2008 09:11:09 -0500
Received: from [199.232.76.173] (port=41435 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LDg4K-0000rQ-Tq
	for qemu-devel@nongnu.org; Fri, 19 Dec 2008 09:11:08 -0500
Received: from fg-out-1718.google.com ([72.14.220.153]:57219)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1LDg4K-0004uk-GW
	for qemu-devel@nongnu.org; Fri, 19 Dec 2008 09:11:08 -0500
Received: by fg-out-1718.google.com with SMTP id l26so386631fgb.8
	for <qemu-devel@nongnu.org>; Fri, 19 Dec 2008 06:11:07 -0800 (PST)
Message-ID: <761ea48b0812190611g1e3fe5c0ndf6fa23138cf7caf@mail.gmail.com>
Date: Fri, 19 Dec 2008 15:11:07 +0100
From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
Subject: Re: [Qemu-devel] [6106] Implement default-NaN mode.
In-Reply-To: <E1LDfnO-0005EK-1k@cvs.savannah.gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <E1LDfnO-0005EK-1k@cvs.savannah.gnu.org>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Fri, Dec 19, 2008 at 2:53 PM, Paul Brook <paul@nowt.org> wrote:
> Revision: 6106
>          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6106
> Author:   pbrook
> Date:     2008-12-19 13:53:37 +0000 (Fri, 19 Dec 2008)
>
> Log Message:
> -----------
> Implement default-NaN mode.
>
> Signed-off-by: Paul Brook <paul@codesourcery.com>
>
> Modified Paths:
> --------------
>    trunk/fpu/softfloat-specialize.h
>    trunk/fpu/softfloat.h
>    trunk/target-arm/helper.c
[...]
> Modified: trunk/target-arm/helper.c
> ===================================================================
> --- trunk/target-arm/helper.c   2008-12-19 13:37:53 UTC (rev 6105)
> +++ trunk/target-arm/helper.c   2008-12-19 13:53:37 UTC (rev 6106)
> @@ -2334,6 +2334,8 @@
>         }
>         set_float_rounding_mode(i, &env->vfp.fp_status);
>     }
> +    if (changed & (1 << 25))
> +        set_default_nan_mode((val & (1 << 25)) != 0, &env->vfp.fp_status);
>
>     i = vfp_exceptbits_to_host((val >> 8) & 0x1f);
>     set_float_exception_flags(i, &env->vfp.fp_status);

Doesn't this require an update to the way flags are computed in
target-arm/cpu.h/cpu_get_tb_cpu_state?

Also I guess the comment at end of vfp_set_fpscr needs some
update to reflect the handling of DN :-)


Laurent