From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH -v2 1/2] Log reset events
Date: Fri, 16 Jan 2009 13:12:39 +0100 [thread overview]
Message-ID: <761ea48b0901160412i67bb876flcb0070ccdf4ac120@mail.gmail.com> (raw)
In-Reply-To: <49707A15.5030803@suse.de>
On Fri, Jan 16, 2009 at 1:14 PM, Kevin Wolf <kwolf@suse.de> wrote:
[..]
>> @@ -159,6 +159,12 @@ static void cpu_reset_model_id(CPUARMState *env, uint32_t id)
>> void cpu_reset(CPUARMState *env)
>> {
>> uint32_t id;
>> +
>> + if (qemu_loglevel_mask(CPU_LOG_RESET)) {
>> + fprintf(logfile, "CPU Reset (CPU %d)\n", env->cpu_index);
>> + cpu_dump_state(env, logfile, fprintf, 0);
>
> Shouldn't that be qemu_log() and log_cpu_state() now?
Yes. Sorry Jan :)
A trick to check things are done properly is to make sure you
don't ever use logfile or loglevel variables.
Laurent
next prev parent reply other threads:[~2009-01-16 12:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 10:05 [Qemu-devel] [RESEND][PATCH 1/2] Log reset events Jan Kiszka
2009-01-16 10:20 ` Laurent Desnogues
2009-01-16 11:32 ` [Qemu-devel] " Jan Kiszka
2009-01-16 11:56 ` [Qemu-devel] [PATCH -v2 " Jan Kiszka
2009-01-16 12:14 ` Kevin Wolf
2009-01-16 12:12 ` Laurent Desnogues [this message]
2009-01-16 12:25 ` Kevin Wolf
2009-01-16 12:24 ` Laurent Desnogues
2009-01-16 12:27 ` [Qemu-devel] " Jan Kiszka
2009-01-16 13:35 ` Jan Kiszka
2009-01-16 13:52 ` Kevin Wolf
2009-01-16 14:16 ` [Qemu-devel] [PATCH -v3 " Jan Kiszka
2009-01-16 15:05 ` Kevin Wolf
2009-01-16 15:35 ` [Qemu-devel] " Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=761ea48b0901160412i67bb876flcb0070ccdf4ac120@mail.gmail.com \
--to=laurent.desnogues@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).