From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LNnZ3-0004kb-AP
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 07:12:41 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LNnZ2-0004iU-Jx
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 07:12:40 -0500
Received: from [199.232.76.173] (port=34468 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LNnZ2-0004i4-7S
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 07:12:40 -0500
Received: from fg-out-1718.google.com ([72.14.220.157]:3492)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1LNnZ1-00078L-Td
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 07:12:40 -0500
Received: by fg-out-1718.google.com with SMTP id 19so787200fgg.8
	for <qemu-devel@nongnu.org>; Fri, 16 Jan 2009 04:12:39 -0800 (PST)
Message-ID: <761ea48b0901160412i67bb876flcb0070ccdf4ac120@mail.gmail.com>
Date: Fri, 16 Jan 2009 13:12:39 +0100
From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
Subject: Re: [Qemu-devel] [PATCH -v2 1/2] Log reset events
In-Reply-To: <49707A15.5030803@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <49705BCF.8020506@siemens.com>
	<761ea48b0901160220o371db87m94c4ad83a2f65a09@mail.gmail.com>
	<49707035.2000606@siemens.com> <49707600.3070509@siemens.com>
	<49707A15.5030803@suse.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Fri, Jan 16, 2009 at 1:14 PM, Kevin Wolf <kwolf@suse.de> wrote:
[..]
>> @@ -159,6 +159,12 @@ static void cpu_reset_model_id(CPUARMState *env, uint32_t id)
>>  void cpu_reset(CPUARMState *env)
>>  {
>>      uint32_t id;
>> +
>> +    if (qemu_loglevel_mask(CPU_LOG_RESET)) {
>> +        fprintf(logfile, "CPU Reset (CPU %d)\n", env->cpu_index);
>> +        cpu_dump_state(env, logfile, fprintf, 0);
>
> Shouldn't that be qemu_log() and log_cpu_state() now?

Yes. Sorry Jan :)

A trick to check things are done properly is to make sure you
don't ever use logfile or loglevel variables.


Laurent