From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LNnkq-0006sW-W5
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 07:24:53 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LNnkp-0006rx-D5
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 07:24:51 -0500
Received: from [199.232.76.173] (port=42458 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LNnkp-0006rt-88
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 07:24:51 -0500
Received: from fg-out-1718.google.com ([72.14.220.154]:1434)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1LNnkp-0000Sf-0B
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 07:24:51 -0500
Received: by fg-out-1718.google.com with SMTP id 19so789461fgg.8
	for <qemu-devel@nongnu.org>; Fri, 16 Jan 2009 04:24:49 -0800 (PST)
Message-ID: <761ea48b0901160424g3903e31aw484bcc86280181d@mail.gmail.com>
Date: Fri, 16 Jan 2009 13:24:49 +0100
From: "Laurent Desnogues" <laurent.desnogues@gmail.com>
Subject: Re: [Qemu-devel] [PATCH -v2 1/2] Log reset events
In-Reply-To: <49707CD2.8090003@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <49705BCF.8020506@siemens.com>
	<761ea48b0901160220o371db87m94c4ad83a2f65a09@mail.gmail.com>
	<49707035.2000606@siemens.com> <49707600.3070509@siemens.com>
	<49707A15.5030803@suse.de>
	<761ea48b0901160412i67bb876flcb0070ccdf4ac120@mail.gmail.com>
	<49707CD2.8090003@suse.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Fri, Jan 16, 2009 at 1:25 PM, Kevin Wolf <kwolf@suse.de> wrote:
> Maybe qemu_log() should be a function rather than a macro? Then loglevel
> and logfile could be static and the build would break if you try to use
> them outside the logging code.

I think the intent is to make sure no useless call is made if not needed.
Of course that'd mean conditionally defining "empty" macros which is
currently not the case.


Laurent