From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LTkjd-0008Jw-8u
	for qemu-devel@nongnu.org; Sun, 01 Feb 2009 17:24:13 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LTkjc-0008JY-AX
	for qemu-devel@nongnu.org; Sun, 01 Feb 2009 17:24:12 -0500
Received: from [199.232.76.173] (port=59601 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LTkjc-0008JR-33
	for qemu-devel@nongnu.org; Sun, 01 Feb 2009 17:24:12 -0500
Received: from fg-out-1718.google.com ([72.14.220.159]:54983)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1LTkjb-00048T-KS
	for qemu-devel@nongnu.org; Sun, 01 Feb 2009 17:24:11 -0500
Received: by fg-out-1718.google.com with SMTP id e21so473697fga.8
	for <qemu-devel@nongnu.org>; Sun, 01 Feb 2009 14:24:08 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4985FD31.4010000@mail.berlios.de>
References: <494D18B1.8080900@mail.berlios.de>
	<4985FD31.4010000@mail.berlios.de>
Date: Sun, 1 Feb 2009 23:24:08 +0100
Message-ID: <761ea48b0902011424s6bebea3dj7cc7e6c106b6adca@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Add single stepping option for all targets
From: Laurent Desnogues <laurent.desnogues@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sun, Feb 1, 2009 at 8:51 PM, Stefan Weil <weil@mail.berlios.de> wrote:
> Stefan Weil schrieb:
>> This patch replaces the compile time options SH4_SINGLE_STEP,
>> DO_SINGLE_STEP and MIPS_SINGLE_STEP
>> by a command line option -singlestep.
>>
>> It also adds single step mode for targets which did not have a compile
>> time option,
>> so all system emulations can be used with -singlestep. Please note that
>> I did only run a short test for i386 and mips targets.
>>
>> A new monitor command is provided to enable or disable single step mode.
>> The monitor command "info status" was modified to display single step
>> mode when activated.
>>
>> Single stepping in Qemu's system emulation mode is useful to see the cpu
>> state
>> for each cpu instruction when used with -d in_asm,cpu. It is also a
>> simple way to slow down the emulation.
>>
>> The patch does not add single step mode for Qemu's user mode emulation.
>> Would this be useful, too?
>>
>> Kind regards
>> Stefan Weil
>>
>>
>
> Hello,
>
> here is an update of the patch. Please apply it to Qemu trunk.

I have two comments:

   - as Stuart previously wrote, user mode would be useful to
     have

   - shouldn't you also prevent block chaining from being done
     for this feature to be really useful?


Laurent