Re: [Qemu-devel] [PATCH 5/7] clean build: Fix remaining cris warnings

[Laurent Desnogues <laurent.desnogues@gmail.com>]

On Sun, Feb 22, 2009 at 12:03 AM, Stuart Brady <sdbrady@ntlworld.com> wrote:
> On Sat, Feb 21, 2009 at 08:00:55PM +0100, Jan Kiszka wrote:
>> diff --git a/target-cris/translate.c b/target-cris/translate.c
>> index f575e63..954b038 100644
>> --- a/target-cris/translate.c
>> +++ b/target-cris/translate.c
>> @@ -2613,7 +2613,7 @@ static unsigned int dec_move_pm(DisasContext *dc)
>>  static unsigned int dec_movem_mr(DisasContext *dc)
>>  {
>>       TCGv_i64 tmp[16];
>> -        TCGv tmp32;
>> +        TCGv tmp32 = 0;
>>       TCGv addr;
>>       int i;
>>       int nr = dc->op2 + 1;
>
> Hmm, GCC just gets it wrong here -- and 0 isn't really very meaningful.
> At the very least, shouldn't there be a comment?  Something like Linux's
> uninitialized_var() macro might be worth considering...

Some targets use TCGV_UNUSED_I32/I64.  I would initialize tmp32
to that value in an additional else part to the first if (nr & 1).  That
should silence gcc.


Laurent