Re: [Qemu-devel] [PATCH 1/3] Fix correct reset value for ARM CP15 c1 auxiliary control register

[Laurent Desnogues <laurent.desnogues@gmail.com>]

On Fri, Feb 27, 2009 at 11:12 PM, Riku Voipio <riku.voipio@iki.fi> wrote:
> From: Juha Riihimäki <juha.riihimaki@nokia.com>
>
> According to ARM Cortex A8 Technical Reference Manual, the reset value for CP15 c1 auxiliary control
> register is 2, not zero (page 3.12).

Out of curiosity does that change anything for your tests?

Laurent

Acked-by: Laurent Desnogues <laurent.desnogues@gmail.com>

> Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
> ---
>  target-arm/helper.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index 3250fb8..883f8ee 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -1694,7 +1694,7 @@ uint32_t HELPER(get_cp15)(CPUState *env, uint32_t insn)
>             case ARM_CPUID_ARM11MPCORE:
>                 return 1;
>             case ARM_CPUID_CORTEXA8:
> -                return 0;
> +                return 2;
>             default:
>                 goto bad_reg;
>             }
> --
> 1.6.1.3
>
>
> --
> "rm -rf" only sounds scary if you don't have backups
>
>
>