From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LdBSB-00039l-DE
	for qemu-devel@nongnu.org; Fri, 27 Feb 2009 17:45:11 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LdBS7-00038b-K5
	for qemu-devel@nongnu.org; Fri, 27 Feb 2009 17:45:10 -0500
Received: from [199.232.76.173] (port=60017 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LdBS7-00038U-5y
	for qemu-devel@nongnu.org; Fri, 27 Feb 2009 17:45:07 -0500
Received: from mail-fx0-f175.google.com ([209.85.220.175]:49577)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1LdBS6-0001dw-Os
	for qemu-devel@nongnu.org; Fri, 27 Feb 2009 17:45:06 -0500
Received: by fxm23 with SMTP id 23so1175857fxm.34
	for <qemu-devel@nongnu.org>; Fri, 27 Feb 2009 14:45:03 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <20090227221233.GA422@kos.to>
References: <20090227221233.GA422@kos.to>
Date: Fri, 27 Feb 2009 23:45:03 +0100
Message-ID: <761ea48b0902271445l1efa1396j66b53fd3cc4e2442@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] Fix correct reset value for ARM CP15 c1
	auxiliary control register
From: Laurent Desnogues <laurent.desnogues@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Fri, Feb 27, 2009 at 11:12 PM, Riku Voipio <riku.voipio@iki.fi> wrote:
> From: Juha Riihim=E4ki <juha.riihimaki@nokia.com>
>
> According to ARM Cortex A8 Technical Reference Manual, the reset value fo=
r CP15 c1 auxiliary control
> register is 2, not zero (page 3.12).

Out of curiosity does that change anything for your tests?

Laurent

Acked-by: Laurent Desnogues <laurent.desnogues@gmail.com>

> Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
> ---
>  target-arm/helper.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index 3250fb8..883f8ee 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -1694,7 +1694,7 @@ uint32_t HELPER(get_cp15)(CPUState *env, uint32_t i=
nsn)
>             case ARM_CPUID_ARM11MPCORE:
>                 return 1;
>             case ARM_CPUID_CORTEXA8:
> -                return 0;
> +                return 2;
>             default:
>                 goto bad_reg;
>             }
> --
> 1.6.1.3
>
>
> --
> "rm -rf" only sounds scary if you don't have backups
>
>
>