From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LfwlU-0002JQ-9U
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 08:40:32 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LfwlS-0002Il-HP
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 08:40:31 -0500
Received: from [199.232.76.173] (port=35927 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LfwlS-0002Ie-AX
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 08:40:30 -0500
Received: from mail-fx0-f175.google.com ([209.85.220.175]:36190)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1LfwlR-0007z2-No
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 08:40:30 -0500
Received: by fxm23 with SMTP id 23so635291fxm.34
	for <qemu-devel@nongnu.org>; Sat, 07 Mar 2009 05:40:27 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1236428435-28631-1-git-send-email-felipe.contreras@gmail.com>
References: <1236428435-28631-1-git-send-email-felipe.contreras@gmail.com>
Date: Sat, 7 Mar 2009 14:40:27 +0100
Message-ID: <761ea48b0903070540l2bb59605o46d57209600501e1@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Revert "Use the host exit syscall for
	exiting (Lauro Ramos Venancio)."
From: Laurent Desnogues <laurent.desnogues@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sat, Mar 7, 2009 at 1:20 PM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> This breaks pthread_join on arm-linux-user.

I am not sure the fix is correct.  If you run tests/testthread.c you'll
notice the thread2 doesn't print the 20 values it should.

BTW it looks like this test doesn't run on i386 and x86_64:  it
ends immediately.


Laurent

> ---
>  linux-user/syscall.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 40eab4e..572fa0a 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -156,7 +156,6 @@ static type name (type1 arg1,type2 arg2,type3 arg3,type4 arg4,type5 arg5,   \
>  }
>
>
> -#define __NR_sys_exit __NR_exit
>  #define __NR_sys_uname __NR_uname
>  #define __NR_sys_faccessat __NR_faccessat
>  #define __NR_sys_fchmodat __NR_fchmodat
> @@ -198,7 +197,6 @@ static int gettid(void) {
>     return -ENOSYS;
>  }
>  #endif
> -_syscall1(int,sys_exit,int,status)
>  _syscall1(int,sys_uname,struct new_utsname *,buf)
>  #if defined(TARGET_NR_faccessat) && defined(__NR_faccessat)
>  _syscall4(int,sys_faccessat,int,dirfd,const char *,pathname,int,mode,int,flags)
> @@ -3433,7 +3431,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
>  #endif
>         gdb_exit(cpu_env, arg1);
>         /* XXX: should free thread stack and CPU env */
> -        sys_exit(arg1);
> +        _exit(arg1);
>         ret = 0; /* avoid warning */
>         break;
>     case TARGET_NR_read:
> --
> 1.6.2
>
>
>
>